Instead of going file by file, feed them to cmake at once.
Should improve build times on some systems.
Details
Details
- Reviewers
sitter - Group Reviewers
Frameworks - Commits
- R249:5a70e96795f1: Make it possible to generate po files in parallel
tests still pass, got kalgebra translated
Diff Detail
Diff Detail
- Repository
- R249 KI18n
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
As discussed on telegram: the proposed change makes it a different problem. Now instead of running serial all the time, it'd fork bomb all the time (peaks at 3671 forks for plasma-desktop 5.12 when run on a fairly fast system with SSD).
Also, missing adjustment to build-tsfiles.cmake ;)
Comment Actions
Ingenious code!
You left some debug clutter behind though.
Also, the if i statement is inconsistent between the two files
if (i EQUAL ${numberOfProcesses}) vs. if (i GREATER ${numberOfProcesses})
cmake/build-pofiles.cmake | ||
---|---|---|
45 | I think !(code EQUAL 0) may be more explicit here. | |
62 | debug | |
63 | no space after if. | |
64 | debug |
cmake/build-tsfiles.cmake | ||
---|---|---|
75 | This doesn't belong here, does it? It's also defined in execute_process() and from looking at the docs it would only be set once. |