This macro helps with setting up all the boilerplate CMake code needed
to instruct automoc about the custom C++ macros used to define Qt-style
plugin class instances.
Details
Details
- Reviewers
apol - Group Reviewers
Build System Frameworks - Commits
- R240:36d42640576e: Add ECMSetupQtPluginMacroNames
Diff Detail
Diff Detail
- Repository
- R240 Extra CMake Modules
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Questions had been:
A) names of macro and arguments okay?
B) other/similar/related use cases which should be covered?
C) how to design argument passing for all the arg1, arg2, arg3? Is the currrent approach sane or how to support someone needing some arg5?
No answers all the time mapped to: current approach okay :)
For usage & purpose of this macro see D11294, D11295, D11296
Also related:
- intermediate non-ecm-macro-based fixes for KF5 modules by D10733, D10732, D10724
- related CMake issue https://gitlab.kitware.com/cmake/cmake/issues/17750
Would push Monday, March 19th if no-one objects or has some comment.
Comment Actions
Thanks for having had a look :)
Do you think it would be possible to come up with a test for it?
Sadly no experience with cmake stuff testing and no initial idea how to write such tests. So would need some days of work, where I have other things more appealing to me :(