Differential D10737

Remove dead code in the ReceiveNotificationsPlugin
AbandonedPublic
Actions

Authored by nicolasfella on Feb 22 2018, 10:54 AM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Summary

It doesn't make sense to ask the desktop NotificationsPlugin for it's notifications because they come from the phone anyway. It would make sense to ask the Sendnotifications plugin, but that's not implemented atm.

Test Plan

Receiving notifications still works

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
sendnotis
Lint
No Linters Available
Unit
No Unit Test Coverage
nicolasfella requested review of this revision.Feb 22 2018, 10:54 AM
nicolasfella created this revision.
mtijink added a subscriber: mtijink.Feb 24 2018, 2:44 PM

Wouldn't it make more sense to implement the required functionality the SendNotifications plugin instead of removing stuff here?

albertvaka added a subscriber: albertvaka.Mar 7 2018, 11:00 AM

Yup, I think it is correct to request the existing notifications when the device is connected.

apol requested changes to this revision.Mar 16 2018, 10:22 PM
apol added a subscriber: apol.

See into @mtijink suggestion.

This revision now requires changes to proceed.Mar 16 2018, 10:22 PM
nicolasfella abandoned this revision.Mar 23 2018, 6:54 PM

Revision Contents
Changeset List

Diff 27766

View Options

src/org/kde/kdeconnect/Plugins/ReceiveNotificationsPlugin/ReceiveNotificationsPlugin.java

Loading...