Differential D10731

Fix the quick tiling of maximized windows
AbandonedPublic
Actions

Authored by pedroarthurp on Feb 22 2018, 12:54 AM.

Details

Reviewers
graesslin
mart
Summary

If the user maximizes a window and then try to quick tile this same window using keyboard shortcuts, the user will find that kwin will restore the initial geometry of the window. This patch restores the expected behavior: a maximized window will get tiled in the requested position.

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
pedroarthurp created this revision.Feb 22 2018, 12:54 AM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 22 2018, 12:54 AM
Restricted Application added subscribers: KWin, kwin. · View Herald Transcript
pedroarthurp requested review of this revision.Feb 22 2018, 12:54 AM
graesslin requested changes to this revision.Feb 22 2018, 5:51 AM

The quick tiling functionality is fully covered by unit tests. Please add a test case exposing the problem.

The code section has shown to be fragile in the past: did you run the unit tests?

geometry.cpp
3369

This comment doesn't match the code now

3455

Empty newline added

This revision now requires changes to proceed.Feb 22 2018, 5:51 AM
pedroarthurp abandoned this revision.Feb 28 2018, 1:45 AM

Commit 8a2796d280dd7e891724cb6e6d873a57e2ae8c52 fixed this issue in 5.12.0. I was working on previous kwin version and, although I have fixed the issue for myself while ago, I was waiting for a better timing to port to HEAD and to compile/test. It is unnecessary now.

Revision Contents
Changeset List

PathPackages
Mgeometry.cpp (16 lines)

Diff 27748

View Options

geometry.cpp

Loading...