Differential D1073

Solving problem when opening resources folder
AbandonedPublic
Actions

Authored by abrahams on Mar 4 2016, 9:08 PM.

Details

Reviewers
None
Group Reviewers
Krita
Maniphest Tasks
T1464: clicking on Open resource folder takes you to ~/.local/share/krita/krita/krita/ instead of /.local/share/krita/
Summary

It is supposed to solve the problem of krita trying to open the resource folder in .local/share/krita/krita/krita.
I changed some stuff in the file KoResourcePaths.cpp, and it seems to work now.

Please notice that I must confess I have not probably seen the "Big picture" of the file KoResourcePaths.cpp. T us, maybe the few changes I done may have an impact in the others part of Krita using this file.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
dimitril updated this revision to Diff 2566.Mar 4 2016, 9:08 PM
dimitril retitled this revision from to Solving problem when opening resources folder.
dimitril updated this object.
dimitril edited the test plan for this revision. (Show Details)
dimitril added a reviewer: Krita.
dimitril set the repository for this revision to R37 Krita.
dimitril added a task: T1464: clicking on Open resource folder takes you to ~/.local/share/krita/krita/krita/ instead of /.local/share/krita/.
dimitril added a subscriber: Krita.
dkazakov added subscribers: rempt, dkazakov.Mar 7 2016, 12:30 PM

Hi, @dimitril!

I would really like @rempt to have a look at this patch. I am not very good at resource loading code. I have only one stylistic comment:

Could you please delete the commented lines? They are not good to be pushed into repository :)

libs/ui/KisViewManager.cpp
1093

Could you remove the old versions of lines?

rempt added a comment.Mar 9 2016, 7:51 AM

I need to check the changes on windows and osx, but I won't have time for that until after this weekend. First I need to finish the spriter plugin, and in the weekend prepare the 3.0 promo material. But I'm aware of the issue and your patch :-)

abrahams requested changes to this revision.Mar 11 2016, 4:08 PM
abrahams added a reviewer: abrahams.
abrahams added a subscriber: abrahams.

Hi @dimitril, if you make these cleanups to the patch I can test it on Windows. It looks correct, I would be very surprised if there were any problems.

libs/widgetutils/KoResourcePaths.cpp
459

The comments from 452-459 are not informative, please remove them

484

Please remove excess whitespace from lines 484 and 477

This revision now requires changes to proceed.Mar 11 2016, 4:08 PM
dimitril updated this revision to Diff 2757.Mar 13 2016, 4:41 PM
dimitril edited edge metadata.

Removing the unwanted commentaries and empty lines.

abrahams accepted this revision.EditedMar 13 2016, 6:31 PM
abrahams edited edge metadata.

Running Manage Resources -> Open Resource Directory works like it should on Windows. I think this is good to go, unless @rempt expects something on OSX to be different.

This revision is now accepted and ready to land.Mar 13 2016, 6:31 PM
dkazakov added a comment.Aug 17 2016, 7:20 AM

Hi, @abrahams!

Has this patch been pushed already?

abrahams commandeered this revision.Aug 17 2016, 10:31 AM
abrahams edited reviewers, added: dimitril; removed: abrahams.

Hi Dmitry - yes I believe this was pushed but the revision was not closed. I'll take care of that.

This revision now requires review to proceed.Aug 17 2016, 10:31 AM
abrahams abandoned this revision.Aug 17 2016, 10:31 AM
abrahams reclaimed this revision.
abrahams abandoned this revision.
abrahams removed a reviewer: dimitril.

Revision Contents
Changeset List

Diff 2757

View Options

libs/ui/KisViewManager.cpp

Loading...
View Options

libs/widgetutils/KoResourcePaths.cpp

Loading...