Fix ApplicationScreenshots shadow for Breeze Dark.

Authored by akrutzler on Feb 20 2018, 10:29 PM.



If you're using Breeze Dark or probably any other dark theme, the screenshot shadow-gradient will run from white to transparent. With this patch, the shadow runs from the currently set background color to transparent.



Diff Detail

R134 Discover Software Store
No Linters Available
No Unit Test Coverage
akrutzler created this revision.Feb 20 2018, 10:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 20 2018, 10:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
akrutzler requested review of this revision.Feb 20 2018, 10:29 PM
akrutzler edited the summary of this revision. (Show Details)Feb 20 2018, 10:33 PM
akrutzler added reviewers: apol, ngraham.
ngraham accepted this revision.Feb 20 2018, 10:43 PM
ngraham added a reviewer: Discover Software Store.

Beautiful! Lovely gif too. Thanks for that.

This revision is now accepted and ready to land.Feb 20 2018, 10:43 PM

Super nice, thanks!

The gifs were the hardest part :)

Do you have commit access?

Not yet, @ngraham did all the commits for me so far. Just in case, my email is :)

ngraham accepted this revision.Feb 21 2018, 3:23 PM

Since this is a small bugfix, I'd like to land it on the Stable branch (Plasma 5.12). However, I can't easily do this using arc because you did the work on master without a branch (in the future, see Can you put it on a branch and re-base this patch on Plasma 5.12 branch? Here's how to do that:

git checkout -b [branchname] #create a new branch
git fetch # fetch all changes from the remote repo
git rebase --onto origin/Plasma/5.12 master #re-base your branch onto the Plasma/5.12 branch
arc diff --update D10701 #update this diff


akrutzler updated this revision to Diff 27724.Feb 21 2018, 7:08 PM

Rebase to origin/Plasma/5.12.

Thanks! I'll land this later tonight, if Alex doesn't beat me to it.

ngraham closed this revision.Feb 22 2018, 12:07 AM
apol added a comment.Feb 22 2018, 2:45 AM

For some reason, didn't see this review >.<. Thanks!