Differential D10681

preload the expander (the dialog) too
ClosedPublic
Actions

Authored by mart on Feb 20 2018, 1:35 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:8346b3e76ab8: preload the expander (the dialog) too
Summary

when preloading, preload the expander as well, and reparent the
full representation to it, so we have a scene schanged less.
also do a create() of that window (may be worth to do create()
automatically in every Dialog?)

Test Plan

the first open is visibly a lot faster now

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Feb 20 2018, 1:35 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 20 2018, 1:35 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart requested review of this revision.Feb 20 2018, 1:35 PM
davidedmundson accepted this revision.Feb 20 2018, 1:51 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
src/plasmaquick/appletquickitem.cpp
294 ↗(On Diff #27605)

wrap this line in QLoggingCategory::isInfoEnabled

This revision is now accepted and ready to land.Feb 20 2018, 1:51 PM
Closed by commit R242:8346b3e76ab8: preload the expander (the dialog) too (authored by mart). · Explain WhyFeb 20 2018, 1:56 PM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Feb 20 2018, 10:53 PM
broulik added inline comments.
src/plasmaquick/appletquickitem.cpp
295

You should check the PlasmaQuick category, not the default one

Revision Contents
Changeset List

Diff 27606

View Options

src/plasmaquick/appletquickitem.cpp

Loading...
View Options

src/plasmaquick/private/appletquickitem_p.h

Loading...