Details
- Reviewers
lbeltrame - Group Reviewers
Baloo - Commits
- R293:70162de9741e: indexerconfig: Describe some functions
Diff Detail
- Repository
- R293 Baloo
- Branch
- publicdescriptions (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/lib/indexerconfig.h | ||
|---|---|---|
| 45 ↗ | (On Diff #27552) | This makes it unclear if the entire path is used, (e.g. \p path) or whether some special part of the path (the dir) is used for matching. It *might* be nice to have documentation on how exactly (e.g. most-specific wins) the matching works, unless that is documented elsewhere. |
| 47 ↗ | (On Diff #27552) | Is \p true really the right markup here? That's for parameters. You probably want \c true -- even though that will produce exactly the same output, the meaning is different. |
| 53 ↗ | (On Diff #27552) | What does "cached and cleaned up" mean here? (Same applies below) |
| 59 ↗ | (On Diff #27552) | What does "perfectly possible" mean here? This might need one or more examples, or a link to how in- and ex-clusion works. |
- fileindexerconfig: Make descriptions consistent
- indexerconfig: Make descriptions consistent
| src/lib/indexerconfig.h | ||
|---|---|---|
| 53 ↗ | (On Diff #27552) | Here, nothing :-) |
| src/lib/indexerconfig.h | ||
|---|---|---|
| 45 ↗ | (On Diff #27552) | Ouch... This one hurts, but it's to the best of my abilities in English. |
Looks OK to me with some changes (for readability).
| src/file/fileindexerconfig.h | ||
|---|---|---|
| 50 ↗ | (On Diff #27673) | I'd put "index and analyze". Seems nitpicky, but reflects what Baloo does (index first, extraction later). |
| 57 ↗ | (On Diff #27673) | "Descendant folders of an excluded folder can be added and they will be indexed." |
| src/file/fileindexerconfig.h | ||
|---|---|---|
| 25 ↗ | (On Diff #27762) | I just noticed this. Can you do the #include changes as part of a separate commit? |