Optional barcodes in libprison
ClosedPublic

Authored by svuorela on Feb 18 2018, 10:12 AM.

Details

Summary

createBarcode can sometimes return nullpointers. In newer upcoming revisions of libprison, it can happen in more cases, so the code needs a bit robustness for that.

The upcoming changes that are relevant are: https://phabricator.kde.org/D10603

Code written against plasma/5.8

Test Plan

So far, only build tested.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
svuorela created this revision.Feb 18 2018, 10:12 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2018, 10:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
svuorela requested review of this revision.Feb 18 2018, 10:12 AM
svuorela edited the summary of this revision. (Show Details)
davidedmundson accepted this revision.Feb 20 2018, 6:22 PM
This revision is now accepted and ready to land.Feb 20 2018, 6:22 PM
This revision was automatically updated to reflect the committed changes.