Recalculate forms after command form changes
ClosedPublic

Authored by aheinecke on Feb 15 2018, 2:48 PM.

Details

Summary

notifyFormChanged is called by documentcommands when
Form fields are changed. E.g. by Undo / Redo.
We need to recalculate after such changes.

Test Plan

Tested with simple_calculate example.

Run the unit test with the added line commented out and it failed, with the added line it passes.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

(I can't comment on the content of the stream of the patches, but I think you don't need the [PATCH] in the title in any of them - they are clearly patches if they are defined here. And probably not even the (1/3) in the other patches)

(I can't comment on the content of the stream of the patches, but I think you don't need the [PATCH] in the title in any of them - they are clearly patches if they are defined here. And probably not even the (1/3) in the other patches)

My intention with this is to make it obvious which differential is a standalone patch and which are parts of a series. But yes for standalone patches I will omit this. For a series I think it adds a bit clarity, especially if you exchange one patch in a series against another patch etc.

aacid added a subscriber: aacid.Feb 19 2018, 11:32 PM

can you add an autotest for this?

aheinecke updated this revision to Diff 27600.Feb 20 2018, 12:55 PM
aheinecke retitled this revision from [PATCH] Recalculate forms after command form changes to Recalculate forms after command form changes.
aheinecke edited the test plan for this revision. (Show Details)

Extended CalculateTextTest to include undo / redo.

aacid accepted this revision.Feb 21 2018, 11:18 PM
This revision is now accepted and ready to land.Feb 21 2018, 11:18 PM
This revision was automatically updated to reflect the committed changes.