Differential D10537

Convert from old connect syntax to new one
ClosedPublic
Actions

Authored by jtamate on Feb 15 2018, 11:44 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:ec296c0ff511: Convert from old connect syntax to new one
Summary

Starting plasmashell with callgrind I noticed a line:
QObject::connect: No such slot KIO::ListJob::slotTotalSize(KIO::filesize_t) in ..../kdesrc/frameworks/kio/src/core/listjob.cpp:289

Test Plan

start plasmashell. The warning line is gone.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jtamate created this revision.Feb 15 2018, 11:44 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 15 2018, 11:44 AM
jtamate requested review of this revision.Feb 15 2018, 11:44 AM
broulik added a subscriber: broulik.Feb 15 2018, 11:47 AM
broulik added inline comments.
src/core/listjob.cpp
140

const KIO::UDSEntryList &

jtamate updated this revision to Diff 27238.Feb 15 2018, 12:12 PM
jtamate edited the test plan for this revision. (Show Details)

fixed broulik comment.

dfaure requested changes to this revision.Feb 26 2018, 9:03 AM
dfaure added inline comments.
src/core/listjob.cpp
140

missing space after comma
[it wasn't there in SIGNAL/SLOT for string normalization purposes, but here it's a lambda function, not a string anymore]

142

space after ','

288

const KIO::UDSEntryList &

294

const QUrl &

This revision now requires changes to proceed.Feb 26 2018, 9:03 AM
jtamate updated this revision to Diff 28102.Feb 26 2018, 12:17 PM

Fixed David comments.

dfaure accepted this revision.Feb 26 2018, 4:06 PM
This revision is now accepted and ready to land.Feb 26 2018, 4:06 PM
Closed by commit R241:ec296c0ff511: Convert from old connect syntax to new one (authored by jtamate). · Explain WhyFeb 26 2018, 7:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/listjob.h (6 lines)
Msrc/core/listjob.cpp (23 lines)

Diff 28136

View Options

src/core/listjob.h

Loading...
View Options

src/core/listjob.cpp

Loading...