Make the review pop-up a bit more user-friendly
ClosedPublic

Authored by ngraham on Feb 14 2018, 2:11 AM.

Details

Summary

Polish the design of the review input pop-up:

  • Make the button tell you what you need to do
  • Make it impossible to accidentally submit a one-star review

BUG: 390426

Test Plan

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Feb 14 2018, 2:11 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 14 2018, 2:11 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 14 2018, 2:11 AM
ngraham edited the summary of this revision. (Show Details)Feb 14 2018, 2:14 AM
ngraham edited the test plan for this revision. (Show Details)
anemeth added a subscriber: anemeth.EditedFeb 14 2018, 7:06 PM

What purpose does the empty space serve?
If it has no purpose then the Review textbox could be larger or the window smaller.

Also is 1 star the default value? Is that a good idea?

The empty space on the bottom is a bug in Kirigami that I fixed this morning with D10502: Eliminate unnecessary bottom padding on OverlaySheets.

The star rating change is a good idea (because yeah, 1 star as the default is a bad idea), just proposed by someone else this morning, in fact: https://bugs.kde.org/show_bug.cgi?id=390426

I can look into that here.

ngraham planned changes to this revision.Feb 15 2018, 1:04 AM
ngraham updated this revision to Diff 27203.Feb 15 2018, 1:14 AM
  • Merge branch 'master' into review-popup-button-text
  • Also fix 390426
ngraham edited the summary of this revision. (Show Details)Feb 15 2018, 1:16 AM
ngraham edited the test plan for this revision. (Show Details)

Looks good to me. I would change the hover animation. Most places that use star ratings tend to highlight all stars up to where your cursor is located. It gives the impression that you are also enabling the starts up to your location. If your cursor is in the fourth star, then also highlight the 3 start before it.

That's a good idea, but I'm having a bit of trouble with the implementation. If this is otherwise okay, can we land it in its current state, and commit to doing that in a subsequent patch?

apol accepted this revision.Feb 16 2018, 3:44 PM
This revision is now accepted and ready to land.Feb 16 2018, 3:44 PM
This revision was automatically updated to reflect the committed changes.