BUG: 369404
Details
Details
- Reviewers
sebas rkflx - Group Reviewers
Spectacle - Commits
- R166:6742051c6bf5: Fix drag-and-drop to Chromium
Tested in KDE Neon:
- Drag-and-drop to Chromium window works now
- Drag-and-drop to Firefox window still works
- Drag-and-drop to the Desktop still works
- Drag-and-drop to Dolphin window still works
- Drag-and-drop to GIMP window still works
- Drag-and-drop to Gwenview window still works
Diff Detail
Diff Detail
- Repository
- R166 Spectacle
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Sebastian Kügler 2016-09-26 21:49:35 UTC
I don't know which apps read the pixmap from the mimedata directly, so I dunno what this is going to break.
FWIW, I tested some more apps which still seemed to work:
- Thunderbird
- KMail
- Krita
- Inkscape
- LibreOffice
@ngraham More ideas for testing:
- Telegram Desktop
- Java-based apps
Comment Actions
More testing:
- Telegram Desktop (Flatpak package): fails even without this patch: https://github.com/flathub/org.telegram.desktop/issues/23
- Telegram Desktop (Neon package): works
- MyPaint (Flatpak package): fails even without this patch
- MyPaint (Neon package): works
- KolourPaint: works
Comment Actions
Successfully tested with a random Java app (http://www.jhlabs.com/ie/ImageEditor.jar), even if this is only a single example. Interestingly, without the patch this app would say "Untitled", with the patch it would pick up the temporary filename.
I'd say let's go for the patch.
Comment Actions
Thanks, Chromium users will rejoice.
(And I'll have something to test with how arc land will do its auto-rebasing – will do that tomorrow.)
Comment Actions
@ngraham JFYI:
Auto-rebasing my patch based on your change to master worked fine, but for the dependency chain below that there was more work required. I edited D10289#201556 and adapted the wiki.
Comment Actions
Drag-and-drop to the Desktop still works
After getting quite confused when investigating D13249#301132 and in case I ever come across this patch at a later time, let me add a comment (even if it sounds like nitpicking, it's an important realization):
Drag-and-drop to the Desktop did not work before the patch, it only started working with the patch.