RFC: Make KRunner a Dock window
AbandonedPublic

Authored by apol on Feb 6 2018, 1:44 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Summary

Martin requested to make it so on D10197, it breaks on my system so please don't merge.

Test Plan

When I start it looks like it has the focus but the text goes elsewhere

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Feb 6 2018, 1:44 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 6 2018, 1:44 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Feb 6 2018, 1:44 AM

+2

Now we just have to fix whatever this bug in kwin is.
Knowing it only affects docks should narrow it down

There is the panel behavior thing missing which used to be in the old code. A panel does not get keyboard focus. With the panel behavior that can be changed.

apol abandoned this revision.Feb 6 2018, 11:56 AM

There is the panel behavior thing missing which used to be in the old code. A panel does not get keyboard focus. With the panel behavior that can be changed.

The old code was un-usably broken, please provide a patch yourself then.

In D10334#201879, @apol wrote:

There is the panel behavior thing missing which used to be in the old code. A panel does not get keyboard focus. With the panel behavior that can be changed.

The old code was un-usably broken, please provide a patch yourself then.

*sigh* the code used to work when I wrote it. I don't know why it broke and honestly I don't care. I fixed Krunner several times and I'm certainly not going to fix it, now that it got broken again by removing needed code without asking the one who wrote it.