BUG: 379023
Let users choose a ring tone in the settings.
albertvaka |
KDE Connect |
BUG: 379023
Let users choose a ring tone in the settings.
Open settings, choose a ringtone, search for device.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java | ||
---|---|---|
89 | It's not defaulting to RingtoneManager.getDefaultUri(RingtoneManager.TYPE_RINGTONE), right? |
src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java | ||
---|---|---|
89 | It should use the same default like before |
I don't see the need for this setting. Which is the use case for this? I mean, why the default ringtone is not good to find your phone so you might want to change it?
In general, I think settings should only be added when there is a use case for which people might need to change them. Otherwise, I prefer less complexity (both in the UI and in the code).
Why not include looped sound, which could then be identified as specifically KDE Connect. Such as with cordless house phones.
About the KDE Connect-specific ringtone: I'm fine with it, it could be shipped as the default as long as it doesn't make the app size grow by much.
Shipping our own ringtone AND having the setting seems an overkill to me. Since we got an awesome ringtone picker "for free" the complexity seems bearable to me. The actual Activity isn't much bigger in the end
The code looks good to me (didn't test yet though).
The change is small and it actually helps some users, so I'd say this is ok. Shipping our own sound would work too, but I think that actually matters a lot.