withfractional scaling sometimes there are visual glithches
in rendering.
painting areas of the terminal is heavily based on QRegion
which is all integer, and sometimes rounding errors can happen
this mitigates the problem, ensuring an area big enough gets
updated when repainting partial areas that cover eventual
pixel fractions that were rounded away
CCBUG:373232
Details
Details
most of the visual glitches are gone now, a missing pixel line
in the background very rarely still happening but seems a separate issue
somewhere else in the painting code
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Branch
- phab/dirty
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Please add a comment to the code for that.
It might be obvious now, but the next person that looks at that code without knowledge of this change probably has a "huh, what is that?" moment and left wondering why it's done.
Comment Actions
I now get all kinds of extra vertical lines on right side of screen and some horizontal ones near cursor using 1.3 scaling - I didn't see these before the latest patch
My zsh prompt is: kurthindenburg:~/ $ [9:17:48]
vertical lines on right side of the last ]
hortizontal lines below current cursor lines