This feature enables the user to select a "Consecutive" checkbox for a task, and this would mean that this task will be automatically started after the previous one finishes. This feature was requested here: https://bugs.kde.org/show_bug.cgi?id=380445.
Details
- Reviewers
kde-utils-devel aacid - Group Reviewers
KDE Applications - Commits
- R361:9472b36b52cd: Added a feature to execute the next task after the previous one finishes.
Diff Detail
- Repository
- R361 KTimer
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
The KDE Developers group is intended for access control purposes only and not for use in reviews.
I've now added the relevant project mailing list as a subscriber - someone should look into this shortly.
The text could be much better, at least should be "task" and not "tasks" since it applies to a single task.
Also what happens if a task is in loop and the next one is a "consecutive ? and more importantly, what do we think should happen?
prefwidget.ui | ||
---|---|---|
255 | the tooltip and the whatsthis are a bit contradicting the whatsthis seems much better to me. |
Hmm in the actual summary I don't see any "tasks", I assume you've modified it. Well, then the task should not be executed until the user puts the previous one out of the loop. I'll come up with an alternative whatsthis and tooltip texts. Additionally, shouldn't loop and one instance checkboxes be mutually exclusive?? Because they are not, which, by common sense, isn't right.
Consecutive checkbox's "tooltip" property text has been changed to be the same as for "whatsThis" property.
Oh yes, you are right, how silly of me. Apart from that, what do you think about making loop and one instance checkboxes exculsive? But to be honest that should be in another review. Now let's speak about this one. I have changed the "tasks" to "task" and I have changed the tooltip message to be the same as for whatsThis. What now?
Changed the text next to the checkbox from "Consecutive tasks" to "Consecutive task".
I think i forgot about this when my hard disk crashed and burned, i'll try to have a look at it again soon if noone else beats me to it, apologies for forgetting about you.
Oops. Well, that must've been a sad experience. And that's why children you need to back up your data regularly. Anyways, I will wait patiently, but please don't make it too long!
@kde-doc-english Do you think we should update doc/index.docbook to include the new option and give it some more "in depth" explanation, like "if you have a loop and consecutive", the consective is not run until loop is removed?
Some questions regarding the feature "Consecutive"
- add task1 with default delay 1:40
- add task2 and check "Consecutive task" and now the value in colunm "Delay" shows the value 1:40
What is the meaning of the editable value 1:40 and why is this value editable?
Does task2 start with a delay of 1:40 after task1 is finished?
What if I have the non consecutive task1 and task2 with different delays and add a consecutive task3?
Does task3 start after task1 is finished or after task2 is finished?
Yes, task2 will start with delay of 1:40 after task1 finishes.
In second case, task3 will start after task2 finishes. The consecutive task is started with the given delay after the task visually above has finished.
Thanks for clarifying.
But what if I have the non consecutive task1 and task2 with different delays and add a consecutive task3?
Does task3 start after task1 is finished or after task2 is finished or after the task with the longest delay is finished?
Ok, since noone seems to disagree with this i'll commit it in a minute. @fmiroslaw can you please review and comment in @lueck changeset?