Differential D10167

No need to initialize m_usableAdapterwith nullptr
ClosedPublic
Actions

Authored by aacid on Jan 28 2018, 9:24 PM.

Details

Reviewers
dhaumann
drosca
Commits
R269:6b85c766547f: No need to initialize m_usableAdapterwith nullptr
Summary

It's a shared pointer, it points to null by default

Diff Detail

Repository
R269 BluezQt
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
aacid created this revision.Jan 28 2018, 9:24 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 28 2018, 9:24 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
aacid requested review of this revision.Jan 28 2018, 9:24 PM
dhaumann accepted this revision.Jan 28 2018, 9:29 PM
dhaumann added a subscriber: dhaumann.

Looks good to me.

This revision is now accepted and ready to land.Jan 28 2018, 9:29 PM
drosca requested changes to this revision.Jan 28 2018, 9:29 PM

Since it is a shared pointer then it doesn't need explicit initialization and this line can just be removed.

This revision now requires changes to proceed.Jan 28 2018, 9:29 PM
aacid updated this revision to Diff 26155.Jan 28 2018, 9:37 PM

remove the line altogether

drosca accepted this revision.Jan 28 2018, 9:37 PM
This revision is now accepted and ready to land.Jan 28 2018, 9:37 PM
aacid updated this revision to Diff 26156.Jan 28 2018, 9:38 PM
aacid retitled this revision from Initialize m_usableAdapter with nullptr to No need to initialize m_usableAdapterwith nullptr.
aacid edited the summary of this revision. (Show Details)
aacid removed a subscriber: dhaumann.

update message

aacid closed this revision.Jan 28 2018, 9:39 PM

Revision Contents
Changeset List

PathPackages
Msrc/manager_p.cpp (1 line)

Diff 26156

View Options

src/manager_p.cpp

Loading...