Removing all unported/unbuilt applets, dataengines, runners, wallpapers
ClosedPublic

Authored by kossebau on Jan 28 2018, 5:20 PM.

Details

Summary

With no-one having invested into porting/maintaining any of those plugins,
the disadvantages of keeping that code in the development branches
(translators getting data of dead code, developers searching for usage
examples hitting lots of dead code, all the unported plugins/lost work making sad)
are not worth it.

Still looking myself right now to get the "mediawiki" runner working again, so
excluded from that list for now, but would remove if I fail.

(yes, only listing CMakeLists.txt in the review, for simple overview, actual files will be also removed)

Would execute the removal on Feb 15th, to give 2 weeks for everyone to consider
adopting one of those finally :)

Diff Detail

Repository
R114 Plasma Addons
Branch
cleanupunportedcode
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau created this revision.Jan 28 2018, 5:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 28 2018, 5:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Jan 28 2018, 5:20 PM
kossebau edited the summary of this revision. (Show Details)Jan 28 2018, 5:27 PM

+1

FWIW, the original rationale behind leaving them was because I didn't want translators to delete a load of work only to have to redo it.
I've since found that's not how KDE translation works, they get moved to comments in the end of the .pot file - for code restoring from git is super easy should anyone ever want to

kossebau added a comment.EditedJan 28 2018, 8:55 PM

I just saw that 5.12 beta tarballs have all the po files for all the dead applets, runners etc, because of the packaging tools just doing magic stuff (possibly based on Messages.sh content), ignoring any skipped subdirs in the actual buildsystem.

5.12 being an LTS, perhaps it might make sense to do the wiping even earlier and before the 5.12.0 tagging, so that the officially released source code tarballs are clean from all the dead code and all the useless po files for the dead code from the very first real release.

So what about doing the wiping already next Tuesday, Jan 30, two days before tarball creation?
Will see to be around at tomorrow's Plasma hangout and ask there, for some direct Plasma team input/approval.

mart accepted this revision.Jan 29 2018, 10:58 AM
This revision is now accepted and ready to land.Jan 29 2018, 10:58 AM