Match also spdx keys LGPL-2.1 & LGPL-2.1+
ClosedPublic
Actions

Authored by kossebau on Jan 27 2018, 10:43 PM.

Details

Reviewers

davidedmundson
apol

Commits

R244:e5825110c889: Match also spdx keys LGPL-2.1 & LGPL-2.1+

Summary

Solves e.g. missing license key in appdata files generated from
dekstop or json data with those strings.

Repository

R244 KCoreAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

kossebau requested review of this revision.Jan 27 2018, 10:43 PM

Can you please also fix the stupid off by one in the autotest which is why we didn't see this.

for(int i = 1; i < KAboutLicense::LGPL_V2_1 ; i++) { /*current highest enum value*/

should be

This revision is now accepted and ready to land.Jan 28 2018, 1:28 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/kaboutdatatest.cpp (2 lines)
M			src/lib/kaboutdata.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26091	af098b9		Jan 27 2018, 10:43 PM	★	★
Diff 2	26133	18e4d24	R244:e5825110c889444dd92fbd80d97528e4fa733edb	Jan 28 2018, 2:50 PM	★	★