The file system is still searched in the same place as before, which can
be easier to use than qrc while working on those files. Having the data
compiled in simplifies deployment though, particularly on systems without
a standard XDG install layout.
Details
Details
- Reviewers
mlaurent - Group Reviewers
Frameworks KDE PIM - Commits
- R175:730063cb9dc1: Put built-in holiday definitions into qrc
Diff Detail
Diff Detail
- Repository
- R175 KHolidays
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| CMakeLists.txt | ||
|---|---|---|
| 8 | Just curious it's not default in ECM ? I never used it. | |
| CMakeLists.txt | ||
|---|---|---|
| 8 | Yep, I was expecting this to be the default too, but it didn't work without explicitly enabling it. | |
Comment Actions
I'm late to the game, but in general looks good.
Minor comments:
- What's missing (or I miss something) is that it could be that entries exist twice, if in resource and on disk. Since this is not the case right now, this is probably not an issue.
- holidays/holidays.qrc is manually maintained and not auto-generated. This is probably fine as well since we don't expect as many changes as e.g. in the syntax-highlighting repo...
Comment Actions
In that case we prefer the on-disk version, that's what the change in HolidayRegionPrivate does.