Combine source and version into a single piece of metadata
AbandonedPublic

Authored by ngraham on Jan 25 2018, 3:07 AM.

Details

Reviewers
apol
Group Reviewers
Discover Software Store
VDG
Summary

Version and Source are linked properties: in Discover, one is always related to and affected by the other.

This patch displays them together as a single piece of metadata to better communicate the connection, and also as a necessary first step towards possibly using a combobox to change the version.

Supersedes D9976

Test Plan

Tested in KDE Neon. The presentation is best when the version number and source names are short, which generally seems to be the case for every circumstance except Ubuntu-based packaging, as Ubuntu often has really long repo names and provides absurd and borderline incomprehensible version numbers. Even in this worst-case scenario, it's still not too bad IMHO.

Krita, before:

Krita, after:

Blender, before:

Blender, after:

Corebird, before:

Corebird, after:

Discord, before:

Discord, after:

Firefox, before:

Firefox, after:

GNOME Recipes, before:

GNOME Recipes, after

K3b, before:

K3b, after:

Lincity-NG, before:

LinCity-NG, after:

Diff Detail

Repository
R134 Discover Software Store
Branch
unify-source-and-version
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Jan 25 2018, 3:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 25 2018, 3:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 25 2018, 3:07 AM
ngraham edited the summary of this revision. (Show Details)Jan 25 2018, 3:14 AM
ngraham edited the test plan for this revision. (Show Details)
apol added a comment.Jan 25 2018, 12:03 PM

Would it maybe make sense to just show the version by the displayOrigin in the different places?

libdiscover/resources/AbstractResource.cpp
227

This change we can't integrate in 5.12 at the moment, because i18n()

IMHO the version number itself is valuable information, and I'm always a bit disconcerted when it's not available. Or did you mean something like this:

Version: 2.8.1 from flathub
or
Version: 2.8.1 from neon-xenial-main
or
Version: 2.8.1 from kdeapps
or
Version: 2.8.1 from snappy

libdiscover/resources/AbstractResource.cpp
227

Right, this would be for master, not Plasma/5.12.

I would also change Also available in to Also available:, since adding the version number in front of the sentence doesn't flow correctly in English.

ngraham abandoned this revision.Mar 19 2019, 12:31 AM

Nah.