Differential D10016

[KFileTreeView] Manually expand tree when model tells us to
ClosedPublic
Actions

Authored by broulik on Jan 22 2018, 11:25 AM.

Details

Reviewers
dfaure
mart
Group Reviewers
Plasma
Commits
R135:af9284852c49: [KFileTreeView] Manually expand tree when model tells us to
Summary

It seems just setting the current index isn't enough to expand all the way down.

BUG: 389305
FIXED-IN: 5.12.0

Test Plan

Ran

kdialog --getexistingdirectory /home/kaiuwe/Projekte/kf5/plasma-workspace/build

and it expanded all the way down to "build". Previously it would only expand "home"

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 22 2018, 11:25 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 22 2018, 11:25 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 22 2018, 11:25 AM
broulik edited the summary of this revision. (Show Details)
mart accepted this revision.Jan 23 2018, 11:12 AM
This revision is now accepted and ready to land.Jan 23 2018, 11:12 AM
Closed by commit R135:af9284852c49: [KFileTreeView] Manually expand tree when model tells us to (authored by broulik). · Explain WhyJan 25 2018, 9:46 AM
This revision was automatically updated to reflect the committed changes.
dfaure added a comment.Feb 28 2018, 6:06 PM

Wow, I just wanted to say thank you. This bug has been bugging me for many years (though never enough to actually take the time to look into it...). You rock, Kai Uwe.

Revision Contents
Changeset List

Diff 25930

View Options

src/platformtheme/kfiletreeview.cpp

Loading...