People rgeorgiev

rgeorgiev (Radoslav Georgiev)
User

Projects

User does not belong to any projects.

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 21 2019, 9:21 PM (248 w, 5 d)
Availability
Available

Recent Activity
View All

Nov 9 2020

rgeorgiev added a comment to D23518: Disable media controls and tabsrunner in Firefox again.

I think media controls should be enabled by default in private mode in Firefox. The reason why I think so is that Firefox has an option which allows the user to enable or disable each individual extension in incognito mode. It even asks the user about this explicitly on installation of an extension which has the capability to run in this mode.

Nov 9 2020, 10:28 PM · Plasma

Jul 23 2019

rgeorgiev abandoned D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work.

@broulik Hmm, now I think that I understood the rationale why SoundCloud support is activated using the Enhanced Media Controls option. As you commented on my other revision (D22632), SoundCloud uses the Media Session API, support for which is enabled using the aforementioned option. My fault for making uniformed changes :D

Jul 23 2019, 7:36 PM · Plasma
rgeorgiev abandoned D22632: Implement support for the "next" and "previous" actions in SoundCloud.
Jul 23 2019, 7:28 PM · Plasma
rgeorgiev added a comment to D22632: Implement support for the "next" and "previous" actions in SoundCloud.
In D22632#499813, @broulik wrote:

-1
Site-specific workarounds are not in scope for this extension.
Also, SoundCloud uses Media Session API and provides callbacks on its own.

Jul 23 2019, 7:27 PM · Plasma
rgeorgiev planned changes to D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work.
In D22631#499815, @broulik wrote:

I'm confused - what does this change? There's no context, so I can't tell where it's being moved to. Soundcloud works fine here. You might want to enable "Enhanced Media Controls" in settings.

Jul 23 2019, 7:21 PM · Plasma

Jul 21 2019

rgeorgiev updated the diff for D22632: Implement support for the "next" and "previous" actions in SoundCloud.
Jul 21 2019, 10:09 PM · Plasma
rgeorgiev updated the diff for D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work.
Jul 21 2019, 10:08 PM · Plasma
rgeorgiev added a dependent revision for D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work: D22632: Implement support for the "next" and "previous" actions in SoundCloud.
Jul 21 2019, 9:33 PM · Plasma
rgeorgiev added a dependency for D22632: Implement support for the "next" and "previous" actions in SoundCloud: D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work.
Jul 21 2019, 9:33 PM · Plasma
rgeorgiev requested review of D22632: Implement support for the "next" and "previous" actions in SoundCloud.
Jul 21 2019, 9:33 PM · Plasma
rgeorgiev requested review of D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work.
Jul 21 2019, 9:28 PM · Plasma