Effectively reverts e7c353c7f43766ea04dcb894b4ecd0b1dc659bee
It was decided that this behavior change after an update was not acceptable.
Details
Details
- Reviewers
fvogt davidbekham ngraham davidedmundson - Group Reviewers
Plasma - Commits
- R856:de877a1580ae: Disable media controls and tabsrunner in Firefox again
- Enable p-b-i in incognito mode: didnt get media controls for that tab and not listed in tabs runner
- All other tabs are still found through krunner
- Normal window still gets media controls
- Chrome behaves unchanged
Diff Detail
Diff Detail
- Repository
- R856 Plasma Browser Integration
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Accepting, but I REALLY don't like this as it makes the behaviour on firefox quite different compared to other browsers for no good reason.
Comment Actions
Yeah, but I /really really really/ don't like surprise upgrade behaviour that you get this patch and suddenly your incognito windows are being publicly broadcast everywhere. It could lead to something quite bad.
The whole situation sucks, but I don't think we have a choice.
| extension/extension-utils.js | ||
|---|---|---|
| 28 | may as well keep this? | |
Comment Actions
I think media controls should be enabled by default in private mode in Firefox. The reason why I think so is that Firefox has an option which allows the user to enable or disable each individual extension in incognito mode. It even asks the user about this explicitly on installation of an extension which has the capability to run in this mode.
I understand the point about leakage of private information from incognito windows but I think the generic (and most straightforward) solution to this problem is just to disable the extension in private mode.