- User Since
- Aug 7 2019, 8:59 AM (11 w, 51 m)
Aug 9 2019
Sure, I've added the comment
Added isChildOf(source, favoritesView) which is probably needed.
I was reluctant to introduce a new variable with such a broad scope (kickoff.dragStartRow) but using the startRow from DropArea would sometimes still mess up the order - startRow would be set to whatever new current index every time the user moved the cursor back inside DropArea, so it would be snapping back to the wrong position. It's not really something a user would commonly do, so I can edit the code to use it instead. Otherwise, startRow wasn't used anywhere so I removed it completely.
Yes, getting into it was pretty straightforward and quick, KDE team did a great job!
Thank you, this was my first ever contribution to FOSS!
I have submitted the fix for the TabBar here: https://phabricator.kde.org/D23036
I'm not quite sure about who to add as reviewers though.
I didn't make a third copy of the positioning code, instead I put it all into a separate function.
Aug 8 2019
Removed line 435. I'll try to submit a separate patch for TabBar.
Aug 7 2019
I also couldn't reproduce the gray overlay (which is caused by tabBarSeparator having a wrong size and taking the whole view - yesterday I could reproduce it but no more) that is shown in the comment 16 here: https://bugs.kde.org/show_bug.cgi?id=395390#c16
So it may still be present. Currently, I can't see any separator but it's a different issue.
Line onHeightChanged: onWidthChanged() fixes BUG: 395390
I'm not sure if this is the best solution. For some reason, plasmacomponents/qml/TabBar.qml lacks an onHeightChanged() function but it has onWidthChanged() that seems to do what needs to happen here. Maybe TabBar.qml should be changed instead.