lisin (Konstantin Lisin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 7 2019, 8:59 AM (11 w, 51 m)
Availability
Available

Recent Activity

Aug 9 2019

lisin updated the diff for D23039: Make Kickoff restore favorites order when dragging an item to desktop.

Sure, I've added the comment

Aug 9 2019, 1:37 PM · Plasma
lisin updated the diff for D23039: Make Kickoff restore favorites order when dragging an item to desktop.

Added isChildOf(source, favoritesView) which is probably needed.

Aug 9 2019, 10:17 AM · Plasma
lisin added a comment to D23039: Make Kickoff restore favorites order when dragging an item to desktop.

I was reluctant to introduce a new variable with such a broad scope (kickoff.dragStartRow) but using the startRow from DropArea would sometimes still mess up the order - startRow would be set to whatever new current index every time the user moved the cursor back inside DropArea, so it would be snapping back to the wrong position. It's not really something a user would commonly do, so I can edit the code to use it instead. Otherwise, startRow wasn't used anywhere so I removed it completely.

Aug 9 2019, 10:09 AM · Plasma
lisin requested review of D23039: Make Kickoff restore favorites order when dragging an item to desktop.
Aug 9 2019, 10:02 AM · Plasma
lisin added a comment to D22988: Fix incorrect Kickoff tab bar layout for vertical panels.

Yes, getting into it was pretty straightforward and quick, KDE team did a great job!

Aug 9 2019, 2:26 AM · Plasma
lisin added a comment to D22988: Fix incorrect Kickoff tab bar layout for vertical panels.

Thank you, this was my first ever contribution to FOSS!
I have submitted the fix for the TabBar here: https://phabricator.kde.org/D23036
I'm not quite sure about who to add as reviewers though.

Aug 9 2019, 2:01 AM · Plasma
lisin added a comment to D23036: Fix incorrect initial tabs position for vertical tab bars.

I didn't make a third copy of the positioning code, instead I put it all into a separate function.

Aug 9 2019, 2:00 AM · Frameworks
lisin requested review of D23036: Fix incorrect initial tabs position for vertical tab bars.
Aug 9 2019, 1:59 AM · Frameworks

Aug 8 2019

lisin updated the diff for D22988: Fix incorrect Kickoff tab bar layout for vertical panels.

Removed line 435. I'll try to submit a separate patch for TabBar.

Aug 8 2019, 5:56 PM · Plasma

Aug 7 2019

lisin updated the summary of D22988: Fix incorrect Kickoff tab bar layout for vertical panels.
Aug 7 2019, 11:25 AM · Plasma
lisin added a comment to D22988: Fix incorrect Kickoff tab bar layout for vertical panels.

I also couldn't reproduce the gray overlay (which is caused by tabBarSeparator having a wrong size and taking the whole view - yesterday I could reproduce it but no more) that is shown in the comment 16 here: https://bugs.kde.org/show_bug.cgi?id=395390#c16
So it may still be present. Currently, I can't see any separator but it's a different issue.

Aug 7 2019, 11:22 AM · Plasma
lisin added a comment to D22988: Fix incorrect Kickoff tab bar layout for vertical panels.

Line onHeightChanged: onWidthChanged() fixes BUG: 395390
I'm not sure if this is the best solution. For some reason, plasmacomponents/qml/TabBar.qml lacks an onHeightChanged() function but it has onWidthChanged() that seems to do what needs to happen here. Maybe TabBar.qml should be changed instead.

Aug 7 2019, 10:56 AM · Plasma
lisin requested review of D22988: Fix incorrect Kickoff tab bar layout for vertical panels.
Aug 7 2019, 10:55 AM · Plasma