Fix incorrect initial tabs position for vertical tab bars
ClosedPublic
Actions

Authored by lisin on Aug 9 2019, 1:59 AM.

Details

Reviewers

ngraham
hein

Group Reviewers

Plasma

Maniphest Tasks

T10047: Guerilla UX testing: a GNOME switcher

Commits

R242:144bb9071541: Fix incorrect initial tabs position for vertical tab bars
R242:e2cd97d822d3: Fix incorrect initial tabs position for vertical tab bars

Summary

This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.

BUG: 395390
FIXED-IN: 5.62

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

lisin created this revision.Aug 9 2019, 1:59 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptAug 9 2019, 1:59 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

I didn't make a third copy of the positioning code, instead I put it all into a separate function.

For Kickoff you can test the changes like this:
Place Kickoff in a vertical panel. Restart plasmashell. Open Kickoff.
Before fix: first tab is placed out of bounds (y < 0).
After fix: first tab is positioned correctly (y = 0).

As far as I see, other applets that use PlasmaComponents.TabBar (like Activity Bar, Grouping widget etc) weren't affected by the bug and they still work the same.