User Details
- User Since
- Jun 29 2016, 11:47 AM (408 w, 6 d)
- Availability
- Available
Jan 18 2017
Not sure whether it's worth creating a new issue, but the change on line 44 of kacl.cpp breaks the build if HAVE_POSIX_ACL is false:
Jan 11 2017
I wrote the first patch to be as minimal as possible and to be consistent with the previous coding style. I therefore left the early returns in place.
Found a couple of places in old code where d->w made more sense than d->native to test. Also figured out why the repository got lost last time...
Apparently updating the diff has had the side-effect of:
Following @kfunk comments, I've changed the patch to test d->w rather than d->native, and used nullptr instead of 0 where appropriate.
Dec 2 2016
Agreed that would be more robust. In writing the patch I was seeking consistency with those functions that already did the test, so those would also need to be updated. Are there any situations where the two tests would yield a different result, ie d->native is true and d->w is non-null?