jonathans (Jonathan Schultz)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 29 2016, 11:47 AM (408 w, 6 d)
Availability
Available

Recent Activity

Jan 18 2017

jonathans added a comment to R241:fecf8fbc7348: Use nullptr everywhere.

Not sure whether it's worth creating a new issue, but the change on line 44 of kacl.cpp breaks the build if HAVE_POSIX_ACL is false:

Jan 18 2017, 3:05 AM

Jan 11 2017

jonathans added a comment to D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used..

I wrote the first patch to be as minimal as possible and to be consistent with the previous coding style. I therefore left the early returns in place.

Jan 11 2017, 10:30 PM · Frameworks
jonathans updated the diff for D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used..

Found a couple of places in old code where d->w made more sense than d->native to test. Also figured out why the repository got lost last time...

Jan 11 2017, 7:14 AM · Frameworks
jonathans added a comment to D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used..

Apparently updating the diff has had the side-effect of:

Jan 11 2017, 6:42 AM · Frameworks
jonathans updated the diff for D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used..

Following @kfunk comments, I've changed the patch to test d->w rather than d->native, and used nullptr instead of 0 where appropriate.

Jan 11 2017, 6:39 AM · Frameworks

Dec 2 2016

jonathans added a comment to D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used..

Agreed that would be more robust. In writing the patch I was seeking consistency with those functions that already did the test, so those would also need to be updated. Are there any situations where the two tests would yield a different result, ie d->native is true and d->w is non-null?

Dec 2 2016, 11:11 PM · Frameworks

Jul 4 2016

jonathans retitled D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used. from to Fix bug in kfiledialog.cpp that causes crashing when native widgets are used..
Jul 4 2016, 2:04 AM · Frameworks