User Details
User Details
- User Since
- Aug 2 2018, 12:12 PM (299 w, 2 d)
- Availability
- Available
Aug 10 2018
Aug 10 2018
gkowal updated the diff for D14629: Process IMAP Quota roots with associated quotas only.
Initialize quota lists expectedRoots, expectedUsages, and expectedLimits using C++11 syntax.
gkowal added a comment to D14629: Process IMAP Quota roots with associated quotas only.
@dvratil, I didn't like the initial way of initializing lists, but didn't know how to make it more compact. Thanks for pointing this out. I'll update the patch.
gkowal added a comment to D14554: Fix array access bounds in IMAP resource.
I don't think I have commit access. You can use custos.mentis@gmail.com. Thanks!
Aug 9 2018
Aug 9 2018
gkowal updated the diff for D14629: Process IMAP Quota roots with associated quotas only.
Patch updated including two autotests.
gkowal added a comment to D14629: Process IMAP Quota roots with associated quotas only.
I am working on autotests. Should I put them in the same patch?
Aug 6 2018
Aug 6 2018
gkowal updated the diff for D14629: Process IMAP Quota roots with associated quotas only.
Check if lists are empty using isEmpty() rather than count().
Aug 5 2018
Aug 5 2018
gkowal added a comment to D14629: Process IMAP Quota roots with associated quotas only.
Thanks. Sure, I'll think about some test cases and try to add them to testretrievecollectionmetadatatask.cpp.
gkowal requested review of D14629: Process IMAP Quota roots with associated quotas only.
gkowal updated the diff for D14617: Fix Quota progress bar for quota limit of 2GB and more.
Typo in variable declaration.
gkowal requested review of D14617: Fix Quota progress bar for quota limit of 2GB and more.
Aug 2 2018
Aug 2 2018
gkowal requested review of D14554: Fix array access bounds in IMAP resource.