| dvratil |
| KDE PIM |
ImapQuotaAttribute::serialized() processes IMAP roots assigning corresponding QUOTA and USAGE attributes to each root. It uses three dictionaries: mRoots, mLimits, and mUsages assuming that these dictionaries always have the same number of elements. In a case when mRoots contains more elements than other two dictionaries, this causes referencing to non-existent elements in mLimits and mUsages and segfaults.
Fix this by using mLimits.size() and mUsages.size() in corresponding loops.
BUG: 396980
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
The question is, were these arrays really expected to have the same sizes, and if yes, why could they differ?
The patch still makes sense, though, because it fixes the crash. Code is also in 18.08 branch.
I spoke with Kevin Ottens, he didn't remember about Quota RFC but he told me that better to use this patch so the imap resource will not crash against a buggy server :)
+1 for me too.
@gkowal do you have commit access? If not, please give me your email address and I'll commit the patches in your name.