egorov (Boris Egorov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 23 2016, 10:43 AM (478 w, 4 d)
Availability
Available

Recent Activity

Feb 5 2018

egorov added a comment to D10099: Use single number as filename for screenshot with empty filename template.

Great, works fine now. I'm formally accepting it, but won't land it yet, pending possible future work on the other template. Alternatively, I can land it now, and you can do the other thing in another patch. Your choice.

Feb 5 2018, 3:42 AM · Spectacle
egorov added a comment to D10099: Use single number as filename for screenshot with empty filename template.

how do we present user with such template?

My guess

kdegraphics/spectacle/src/Gui/SettingsDialog/SaveOptionsPage.cpp:95

Ah, got it. I was thinking about second field to introduce this template, don't know why (question about "both" empty templates originates here).

Feb 5 2018, 3:40 AM · Spectacle

Jan 28 2018

egorov added a comment to D10099: Use single number as filename for screenshot with empty filename template.

How about introducing another template like '%#' ...

Question is: how do we present user with such template? We have one, and this patch fixes behavior when it is empty. How to describe this new template? What will we do when both are empty?

Jan 28 2018, 4:29 PM · Spectacle
egorov updated the diff for D10099: Use single number as filename for screenshot with empty filename template.

Fixed "Save As" file naming with empty filename template

Jan 28 2018, 4:27 PM · Spectacle
egorov added a comment to D10099: Use single number as filename for screenshot with empty filename template.

How about introducing another template like '%#' instead of hard coding the '1'?
This would also allow for %#### to pad with zeros.

Jan 28 2018, 3:49 PM · Spectacle
egorov added a comment to D10099: Use single number as filename for screenshot with empty filename template.

Thanks for the patch! Does what it says it does, but I found a corner case: if you delete the template and choose "Save As...", the file save dialog box uses a default filename of ".png". We probably need to add the number there, too.

Jan 28 2018, 3:47 PM · Spectacle

Aug 8 2017

egorov committed R32:2d580f44cf39: Misleading indentation fixes (GCC6) (authored by egorov).
Misleading indentation fixes (GCC6)
Aug 8 2017, 5:02 PM
egorov committed R32:258f9ce801d7: Restore std::move tests, revert part of cf48e4d26257b (authored by egorov).
Restore std::move tests, revert part of cf48e4d26257b
Aug 8 2017, 4:55 PM
egorov committed R32:cf48e4d26257: Make ctors explicit to avoid implicit construction (krazy2) (authored by egorov).
Make ctors explicit to avoid implicit construction (krazy2)
Aug 8 2017, 4:55 PM
egorov committed R32:827b94935714: Fix some foreach loop issues (krazy2) (authored by egorov).
Fix some foreach loop issues (krazy2)
Aug 8 2017, 4:55 PM

Mar 30 2016

egorov committed R33:2d580f44cf39: Misleading indentation fixes (GCC6) (authored by egorov).
Misleading indentation fixes (GCC6)
Mar 30 2016, 4:23 PM
egorov committed R32:ef77b2336941: Misleading indentation fixes (GCC6) (authored by egorov).
Misleading indentation fixes (GCC6)
Mar 30 2016, 3:51 PM
egorov closed D1266: Misleading indentation fixes (GCC6) by committing R32:ef77b2336941: Misleading indentation fixes (GCC6).
Mar 30 2016, 3:51 PM · KDevelop
egorov retitled D1266: Misleading indentation fixes (GCC6) from to Misleading indentation fixes (GCC6).
Mar 30 2016, 3:22 PM · KDevelop