Differential D1266

Misleading indentation fixes (GCC6)
ClosedPublic
Actions

Authored by egorov on Mar 30 2016, 3:22 PM.

Details

Reviewers
mwolff
kfunk
Group Reviewers
KDevelop
Commits
R32:ef77b2336941: Misleading indentation fixes (GCC6)
Summary

These all look innocent enough, but why not to fix them.

Some analysis:

qmljsinterpreter.cpp: Just wrong indentation

makefileresolver.cpp workingDirectory: Looks like this path is never
executed (we call this function only with absolute path)

makefileresolver.cpp res.paths: This one is probably a real issue - it uses
cachedDefines every time instead of only when res.paths.isEmpty().

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
egorov updated this revision to Diff 3029.Mar 30 2016, 3:22 PM
egorov retitled this revision from to Misleading indentation fixes (GCC6).
egorov updated this object.
egorov edited the test plan for this revision. (Show Details)
egorov added a reviewer: KDevelop.
egorov set the repository for this revision to R32 KDevelop.
egorov added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 30 2016, 3:22 PM
mwolff accepted this revision.Mar 30 2016, 3:26 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

nice! thanks

This revision is now accepted and ready to land.Mar 30 2016, 3:26 PM
kfunk accepted this revision.Mar 30 2016, 3:28 PM
kfunk added a reviewer: kfunk.
apol added a subscriber: apol.Mar 30 2016, 3:28 PM

It would be great if you could forward-port changes in qmljs to QtCreator.

Closed by commit R32:ef77b2336941: Misleading indentation fixes (GCC6) (authored by egorov). · Explain WhyMar 30 2016, 3:51 PM
This revision was automatically updated to reflect the committed changes.
egorov mentioned this in R32:ef77b2336941: Misleading indentation fixes (GCC6).

Revision Contents
Changeset List

Diff 3030

View Options

languages/qmljs/libs/qmljs/qmljsinterpreter.cpp

Loading...
View Options

projectmanagers/custommake/makefileresolver/makefileresolver.cpp

Loading...