User Details
- User Since
- Oct 15 2018, 1:39 PM (347 w, 5 d)
- Availability
- Available
Oct 25 2018
Oct 22 2018
grabFocus, tooltip message you posted
Oct 20 2018
const bool grabfocus
different menu label, added tooltip, enabled tooltips
used newer connect style
removed qCDebug, config.sync();
Oct 18 2018
Laurent, please okay the review and land D16240
added const, edited if, for { style
added const, if<space>(
Oct 17 2018
One other bug unrelated to this patch sequence and I wouldn't think it would be specific to korgac. If I don't set the theme it doesn't get stuck printing the message, but it doesn't have the theme. I didn't know if you would have any suggestions off the top of your head, other than start debugging.
KWindowSystem::setUserTime(winId(), 0);
"The most common case is the special value 0 which means not to activate the window after being shown." Whatever that means, because I called it before QDialog::show(); (the documentation doesn't say and I'm assuming if you've already called show() it's too late), and didn't see a getting focus behavior difference in fvwm or kde (tested without this patch, so the Reminder window appeared where it was last).
// KDE with "Focus Follows Mouse - Mouse Precedence" // called with 0, mouse not under window, gets focus // not called, mouse not under window, gets focus // KDE with "Click to Focus" // called with 0, mouse not under window, doesn't get focus // not called, mouse not under window, doesn't get focus // called with 0, mouse under window, gets focus // not called, mouse under window, gets focus
Moved the resize() argument up to be the rectangle default size if the configuration file doesn't have one, in addition to the requested changes.
redoing patch
updated with the two requested changes, setMinimumSize, remove setStyleSheet
will update the patch...
Oct 16 2018
inline comment
marked inline comment as done, this feature was very useful in development
renamed allocateDialog to createDialog
Montel, you asked to change the summary, how about removing it? It's pretty trivial and there's probably nothing more to say than the subject, or do you have something else in mind.
Who does the next step, because as far as I know I don't have permissions to apply the change.