chroniceel (William Tradewell)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Tue, Jan 14, 1:55 AM (4 d, 19 h)
Availability
Available

Recent Activity

Thu, Jan 16

chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

... unless you wanted that in the summary?

Thu, Jan 16, 5:15 PM · Frameworks, Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

Updated diff. It's setting the quality now, and added a brief comment.

Thu, Jan 16, 5:05 PM · Frameworks, Dolphin
chroniceel updated the diff for D26648: Improved quality of JPEG thumbnails.
Thu, Jan 16, 5:03 PM · Frameworks, Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

Ping! I think this got buried. Unless someone else is testing this?

Thu, Jan 16, 3:32 PM · Frameworks, Dolphin

Tue, Jan 14

chroniceel updated the summary of D26648: Improved quality of JPEG thumbnails.
Tue, Jan 14, 4:22 PM · Frameworks, Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

It's not overly scientific, but with this little fix, it can gen ~10 thumbnails a second on my system (1.6 Ghz pentium, ~10MP). This seems on par with png files of a similar size. As far as I can tell, there is not a super huge performance decrease. Please note, I use a potato.

Tue, Jan 14, 4:11 PM · Frameworks, Dolphin
chroniceel updated the diff for D26648: Improved quality of JPEG thumbnails.

Less is more, removing the line appears to be a solution as well. Assuming QImageReader uses sane defaults.

Tue, Jan 14, 3:58 AM · Frameworks, Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

Okay, removing the line appears to have a similar effect to what I already did. I checked over on the imagecreator.cpp file, which appears to handle the thumbnailing of most other image types, and despite also using a QImageReader object, it does not call setQuality. My best guess is that QImageReader uses a sane value by default, and the imagecreator.cpp class lets that ride, ergo good thumbnails. I have no clue why this was set here, nor why it was set to 0.

Tue, Jan 14, 3:53 AM · Frameworks, Dolphin
chroniceel updated the summary of D26648: Improved quality of JPEG thumbnails.
Tue, Jan 14, 3:35 AM · Frameworks, Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

I'm going to delete that line and see what happens.

Tue, Jan 14, 3:31 AM · Frameworks, Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

It appears to me that the setQuality() function is meant to, in this use case, to simply decide what downscaler to use. Higher values mean better quality downscaling.

Tue, Jan 14, 3:29 AM · Frameworks, Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.
Tue, Jan 14, 3:25 AM · Frameworks, Dolphin
chroniceel added a comment to D26648: Improved quality of JPEG thumbnails.

This does not affect the size of the created thumbnail, as all thumbnails are stored as png images regardless of source image type. This simply allows the thumbnailer to downscale the image without the artifacting displayed in the screenshots. I have checked and double checked that the resultant size of the thumbnails remains unchanged.

Tue, Jan 14, 3:20 AM · Frameworks, Dolphin
chroniceel requested review of D26648: Improved quality of JPEG thumbnails.
Tue, Jan 14, 2:05 AM · Frameworks, Dolphin