bdevries (Bart De Vries)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 18 2019, 7:17 PM (46 w, 6 d)
Availability
Available

Recent Activity

Dec 3 2019

bdevries added a comment to D25111: Implement KMessageWidget to report import errors..

No problem.
I will follow up, as promised, with a patch to refactor the internationalization of the info/warning/error messages.

Dec 3 2019, 10:27 PM · Gwenview

Nov 22 2019

bdevries added a comment to D25111: Implement KMessageWidget to report import errors..

Yes, sounds good.
The current patch is quite aligned with what the existing code is doing, so no modification should be required. This patch could then be used as-is.

Nov 22 2019, 9:25 PM · Gwenview
bdevries added inline comments to D25111: Implement KMessageWidget to report import errors..
Nov 22 2019, 2:58 PM · Gwenview
bdevries updated the diff for D25111: Implement KMessageWidget to report import errors..

Internationalize strings.

Nov 22 2019, 2:48 PM · Gwenview

Nov 8 2019

bdevries requested review of D25224: Solve a bug which can happen with multiple files with the same name.
Nov 8 2019, 9:44 PM · Gwenview
bdevries added inline comments to D24875: Importer: convert all file operations to allow remote URLs.
Nov 8 2019, 9:17 PM · Gwenview
bdevries updated the diff for D24875: Importer: convert all file operations to allow remote URLs.

A few additional changes based on Nate's comments.

Nov 8 2019, 9:16 PM · Gwenview

Nov 1 2019

bdevries requested review of D25111: Implement KMessageWidget to report import errors..
Nov 1 2019, 10:50 PM · Gwenview

Oct 31 2019

bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

No, nothing bad will happen. The importer will try to create a subfolder if needed. If it somehow doesn't succeed, it will result in a FileUtils::RenameFailed.
In that case the file will simply be skipped altogether. It will remain untouched on the source device, and it will also not be deleted if the user tells the importer to delete the imported files. Deleting is only done for successfully imported files.
I'm already working on the other patch. Luckily, it seems like it might be relatively simple to implement some basic UI warnings for failed items.

Oct 31 2019, 6:58 PM · Gwenview
bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

For traceability's sake, I would separate the proper error handling into a separate patch/commit.
It's completely missing at the moment, so it seems strange to mix it in with a "new feature".

Oct 31 2019, 3:41 PM · Gwenview

Oct 30 2019

bdevries updated the diff for D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

Register as FileUtils::RenameFailed if the subfolder cannot be created.

Oct 30 2019, 3:33 PM · Gwenview
bdevries added a comment to D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..

You're absolutely right that there needs to be a GUI warning/report of some kind. However, the current importer does not have the infrastructure to handle this: it does nothing with failed imports (of any kind) except print a warning message to stdout. See e.g. the FIXME/warning on lines 208 and 255.

Oct 30 2019, 10:40 AM · Gwenview

Oct 28 2019

bdevries added a comment to D24881: After import, change default action to "keep" instead of "delete"..

I'll certainly consider it.
Let's see if I can find the time. :-)

Oct 28 2019, 9:58 PM · Gwenview
bdevries added a reviewer for D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater).: Gwenview.
Oct 28 2019, 8:43 PM · Gwenview
bdevries requested review of D25016: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Oct 28 2019, 8:40 PM · Gwenview
bdevries updated the diff for D24881: After import, change default action to "keep" instead of "delete"..

Swap keep and delete buttons. This makes keep the default action.

Oct 28 2019, 8:24 PM · Gwenview

Oct 24 2019

bdevries set the repository for D24875: Importer: convert all file operations to allow remote URLs to R260 Gwenview.
Oct 24 2019, 8:31 PM · Gwenview
bdevries updated the diff for D24875: Importer: convert all file operations to allow remote URLs.

Add unit tests and solve bug when mulitiple files of same name exist.

Oct 24 2019, 8:28 PM · Gwenview
bdevries updated the diff for D24875: Importer: convert all file operations to allow remote URLs.

Use QScopedPointer for QIODevice pointers

Oct 24 2019, 2:47 PM · Gwenview
bdevries added a comment to D24881: After import, change default action to "keep" instead of "delete"..

The purpose of this dialog box is to ask the user what should be done with the original files on the source device that the photos were imported from. I.e. deleting them on the source device, e.g. the camera or smartphone. Only the photos that were imported successfully are then deleted from the source device (so not the ones that failed or were not selected to be imported).
BTW, the dialog box pops up after the import itself has been done.

Oct 24 2019, 9:28 AM · Gwenview

Oct 23 2019

bdevries added a reviewer for D24881: After import, change default action to "keep" instead of "delete".: Gwenview.
Oct 23 2019, 8:50 AM · Gwenview
bdevries requested review of D24881: After import, change default action to "keep" instead of "delete"..
Oct 23 2019, 8:48 AM · Gwenview
bdevries added a comment to D24874: Fix temporary path in importer test unit.

Since this is my first ever contribution to KDE: is there anything that I still need to do on my side? Or will this commit be applied without further intervention from me?

Oct 23 2019, 6:58 AM · Gwenview

Oct 22 2019

bdevries abandoned D24876: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Oct 22 2019, 9:43 PM · Gwenview
bdevries requested review of D24876: Create additional subfolders if needed (e.g. when extra slashes in FileNameFormater)..
Oct 22 2019, 9:43 PM · Gwenview
bdevries added a comment to D24874: Fix temporary path in importer test unit.

Sure, my "git" email address is devriesb@gmail.com .

Oct 22 2019, 8:52 PM · Gwenview
bdevries added a dependency for D24875: Importer: convert all file operations to allow remote URLs: D24872: Replace mkdtemp by QTemporaryDir.
Oct 22 2019, 8:48 PM · Gwenview
bdevries added a dependent revision for D24872: Replace mkdtemp by QTemporaryDir: D24875: Importer: convert all file operations to allow remote URLs.
Oct 22 2019, 8:48 PM · Gwenview
bdevries requested review of D24875: Importer: convert all file operations to allow remote URLs.
Oct 22 2019, 8:47 PM · Gwenview
bdevries requested review of D24874: Fix temporary path in importer test unit.
Oct 22 2019, 8:33 PM · Gwenview
bdevries requested review of D24872: Replace mkdtemp by QTemporaryDir.
Oct 22 2019, 8:26 PM · Gwenview