In D623#13740, @akreuzkamp wrote:For the next time, please create one commit for each change. Adding Loader and fixing repeater are separate changes and don't belong in one review request. But let's accept it for now :)
But at least: Please write a more meaningful commit message:
- You added something. Is it feature complete? What's supported, what's missing? (It's enough to write like one sentence about it)
- "Fixed Repeater" simply is not enough. What was wrong about it? What did you change? (please be as accurate as possible)
- "For some reason items are mirrored by Positioner. Most probably due to lack of parent during creation time." I read that, as an issue you introduce with this commit, but there seems to be some fix for it in the code!? Did I misunderstand it?
Please don't be deterred by the "bad" comments. It's mostly nitpicks, that are needed to reach the desired quality (when I fill review requests and Jan reviews them, they'll always look like that, if not worse ;) ). Thanks a lot for your contributions, they are really valuable! I'm especially glad to finally have a Loader! :) :) :)
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Jan 4 2016
Jan 4 2016
Column,Row, Flow, Grid: Properly set implicit w/h. Corrected wrong assumption: Parent of created by Repeater Item is not Repeater but parent of Repeater.
Import: new Function in general is faster then eval.
Item: Added root item which geometry is inner Window w/h. Update html element w/h if implicitWidth/implicitHeight changes. Added cache dom.style as css.
ListModel: Fixed defect in clear function (call this.$model.modelReset(); before $item is cleared).
Loader: Added Loader geometry support.
Parser: Fixed parsing error of QML importing JavaScript.
qml: Removed "return" from setters in createSimpleProperty function. Fixed incorrect behavior when created items were trying to use items that weren't created.
qt: Added enum's used by ScrollView.
Repeater: Corrected wrong assumption: Parent of created by Repeater Item is not Repeater but parent of Repeater. Source code clean up and minor performance improvements.
signal: Allow further execution by catching exceptions.
Dec 5 2015
Dec 5 2015
- Removing config file.
- Fixed computing childrenRect basing on implicit width and height of the children
Dec 3 2015
Dec 3 2015
iandruszkiewicz retitled D623: Added Loader, childrenRect and other fixes. from arcconfig to Added Loader, childrenRect and other fixes..
Dec 2 2015
Dec 2 2015