| iandruszkiewicz |
Added Loader, ComboBox, Screen, childrenRect property. Fixed positioning ugin Row, Column, Flow (to fix mirrored items). Fixed Repeater. Added number and array modles support.
For some reason items are mirrored by Positioner. Most probably due to lack of parent during creation time.
| No Linters Available |
| No Unit Test Coverage |
For the next time, please create one commit for each change. Adding Loader and fixing repeater are separate changes and don't belong in one review request. But let's accept it for now :)
But at least: Please write a more meaningful commit message:
Please don't be deterred by the "bad" comments. It's mostly nitpicks, that are needed to reach the desired quality (when I fill review requests and Jan reviews them, they'll always look like that, if not worse ;) ). Thanks a lot for your contributions, they are really valuable! I'm especially glad to finally have a Loader! :) :) :)
| src/qtcore/qml/elements/QtQuick/ListModel.js | ||
|---|---|---|
| 9 | Why do you remove this line? | |
| src/qtcore/qml/elements/QtQuick/MouseArea.js | ||
| 83 | You're overriding line 75. Why? | |
| src/qtcore/qml/elements/QtQuick/Repeater.js | ||
| 11 | I don't understand this. What are you trying to fix? | |
| 39 | This is wrong. Repeater doesn't add items as it's own children, but adds them to it's parent. | |
| src/qtcore/qml/elements/QtQuick/Row.js | ||
| 26 | Sorry, but this is wrong, too. As already written earlier, Repeaters add their items to their parent. I admit, this is weird behavior, but it's how Qt is doing it. Please undo this change. | |
| src/qtcore/qml/lib/parser.js | ||
| 1688 | Why did you add that? (You should ideally mention and justify it in the commit message) | |
| src/uglify/parse.js | ||
| 580 | Why did you change this? (You should ideally mention and justify it in the commit message) | |
Column,Row, Flow, Grid: Properly set implicit w/h. Corrected wrong assumption: Parent of created by Repeater Item is not Repeater but parent of Repeater.
Import: new Function in general is faster then eval.
Item: Added root item which geometry is inner Window w/h. Update html element w/h if implicitWidth/implicitHeight changes. Added cache dom.style as css.
ListModel: Fixed defect in clear function (call this.$model.modelReset(); before $item is cleared).
Loader: Added Loader geometry support.
Parser: Fixed parsing error of QML importing JavaScript.
qml: Removed "return" from setters in createSimpleProperty function. Fixed incorrect behavior when created items were trying to use items that weren't created.
qt: Added enum's used by ScrollView.
Repeater: Corrected wrong assumption: Parent of created by Repeater Item is not Repeater but parent of Repeater. Source code clean up and minor performance improvements.
signal: Allow further execution by catching exceptions.
Thanks for the review. I fixed the defects you have found in my commits. Please review one more time :)
One commit for each change is difficult to achieve. However I'll be trying to commit as small pieces as possible.
| src/qtcore/qml/elements/QtQuick/ListModel.js | ||
|---|---|---|
| 9 | Indeed, this variable can't be removed. I don't remember if it was removed by me but I'll revert it. | |
| src/qtcore/qml/elements/QtQuick/MouseArea.js | ||
| 83 | hehe again I feel very weird seeing these two overloaded. Please remove these (onmouseout, onmouseover) without self.dom.style.cursor | |
| src/qtcore/qml/elements/QtQuick/Repeater.js | ||
| 11 | If I remember correctly, created objects don't know own parent until some moment of life. Parent must be set as soon as possible (parent properly is created (?)). I am not sure if this is proper place to do so. This issue also should considered as a global "problem" (all components). | |
| 39 | You're right. I'll fix it. Column {
anchors.fill: parent
property string name: "column"
spacing: 10
Repeater{
property string name: "Repeater"
model: 10
delegate: Rectangle {
property string name: "Rectangle"
width: 100
height: 100
color: "red"
Text {
text: parent.parent.name
}
}
}
} | |
| src/qtcore/qml/elements/QtQuick/Row.js | ||
| 26 | OK | |
| src/qtcore/qml/lib/parser.js | ||
| 1688 | It allows to parse two an extra typed of data models for Repeater (number, array) | |
| src/uglify/parse.js | ||
| 580 | I moved variables to function body due to following error Uncaught TypeError: UNARY_POSTFIX is not a function here: while (is("operator") && UNARY_POSTFIX(S.token.value) && !S.token.nlb) { Problem occurs in QML with imported JavaScript (jason xpath) | |
| lib/qt.js | ||
|---|---|---|
| 11990 | There is a mistake here, erroneous new. | |