Feed Advanced Search

Nov 26 2018

habacker added a comment to D17108: JavaImport: Convert Java specific notation '...' into a language independent array definition.

With https://bugs.kde.org/show_bug.cgi?id=401290#c7 I can confirm, that this the related bug is really fixed by this patch.

Nov 26 2018, 10:27 AM · Umbrello

Nov 25 2018

habacker accepted D17108: JavaImport: Convert Java specific notation '...' into a language independent array definition.

Another view is that this patch bypasses the originally described error (the dialog box).

Nov 25 2018, 5:17 PM · Umbrello
okellogg added a comment to D17108: JavaImport: Convert Java specific notation '...' into a language independent array definition.

I changed the title as you suggest.
From my point of view, the whole point of bug 401290 was to get rid of the annoying dialogs popping up.
So I would argue that this does in fact fix the issue, even in a way that has an improvement in portability as a side effect.

Nov 25 2018, 10:36 AM · Umbrello

Nov 23 2018

okellogg updated the summary of D17108: JavaImport: Convert Java specific notation '...' into a language independent array definition.
Nov 23 2018, 5:14 PM · Umbrello
habacker added a comment to D17108: JavaImport: Convert Java specific notation '...' into a language independent array definition.

The title of this commit is inappropriate, because the patch does not fix the initially reported regression, but converts the java specific notation '...' into a language independent array definition.

Nov 23 2018, 7:28 AM · Umbrello

Nov 22 2018

okellogg requested review of D17108: JavaImport: Convert Java specific notation '...' into a language independent array definition.
Nov 22 2018, 7:25 PM · Umbrello

Jan 18 2018

habacker closed T7519: Add php import support to windows installer as Resolved.

Version 2.24.0 contains php import support

Jan 18 2018, 11:49 AM · Umbrello

Jan 8 2018

habacker closed T7608: Add kdevelop-qt-pg to obs project windows:mingw as Resolved.

package has been added

Jan 8 2018, 9:44 AM · Umbrello
habacker closed T7608: Add kdevelop-qt-pg to obs project windows:mingw, a subtask of T7519: Add php import support to windows installer, as Resolved.
Jan 8 2018, 9:44 AM · Umbrello

Dec 16 2017

habacker added a comment to T7519: Add php import support to windows installer.

win64 package is created at https://build.opensuse.org/project/show/home:rhabacker:branches:windows:mingw:win32:KDE4
Need to released to windows:mingw:winxx after finishing sub tasks

Dec 16 2017, 12:49 PM · Umbrello
habacker created T7608: Add kdevelop-qt-pg to obs project windows:mingw.
Dec 16 2017, 12:49 PM · Umbrello

Dec 2 2017

habacker created T7519: Add php import support to windows installer.
Dec 2 2017, 10:05 AM · Umbrello

Aug 6 2017

habacker closed D6846: Fix renaming of combined fragment sections' names by committing R139:7f327bfaba35: Fix renaming of combined fragment sections' names (authored by astranieri).
Aug 6 2017, 10:00 PM · Umbrello
astranieri updated the diff for D6846: Fix renaming of combined fragment sections' names.

Application of code review comments

Aug 6 2017, 7:19 PM · Umbrello

Aug 3 2017

habacker added a comment to D6846: Fix renaming of combined fragment sections' names.

I applied the comments regarding the braces.

Furthermore, I have fixed the patch, in that it was missing:

  • re-naming for some variable to reflect their actual type and be less confusing in my opinion
  • removes unused include directives

While it is nice that you cover this, I do not like mixing the initial fix with unrelated changes, which makes it hard to see what has been really changed and what is only cosmetic. Think about the case you need to inspect single commits say in one year because there is an hidden issue. In case there are commits covering a single topic you can save much time by simply skipping the cosmetic and unrelated commits. With mixed commits you need to inspect every commit if it contains real changes or not.
I do not know if phabricator supports a set of patches in one request. If not feel free to open new review requests for each additional topic. You may collect removing unused include directives patches in a separate local git branch and post them as one patch later to a single review request.

Aug 3 2017, 10:18 PM · Umbrello

Aug 2 2017

astranieri updated the diff for D6846: Fix renaming of combined fragment sections' names.

I applied the comments regarding the braces.

Aug 2 2017, 3:51 PM · Umbrello
astranieri planned changes to D6846: Fix renaming of combined fragment sections' names.

Sure, that's actually my style too. I saw that if blocks are in Java style and I mistakenly thought that would apply to methods as well. I will fix it.

Aug 2 2017, 3:20 PM · Umbrello

Aug 1 2017

habacker added a comment to D6846: Fix renaming of combined fragment sections' names.

looks good otherwise. After fixing the mentioned issues it could be applied to master because this patch changes the location of i18n calls which is not allowed in stable branches.

Aug 1 2017, 10:45 PM · Umbrello

Jul 30 2017

astranieri added a watcher for Umbrello: astranieri.
Jul 30 2017, 7:57 AM

Jul 24 2017

astranieri added a reviewer for D6846: Fix renaming of combined fragment sections' names: habacker.
Jul 24 2017, 3:24 PM · Umbrello

Jul 23 2017

astranieri created D6846: Fix renaming of combined fragment sections' names.
Jul 23 2017, 7:36 AM · Umbrello

Jul 18 2017

habacker added a comment to D6761: Fix else section of alternative combined fragment outside widget box.

We missed the time frame for 2.22.80. Fix will be in release 2.22.90

Jul 18 2017, 4:51 AM · Umbrello
habacker added a comment to D6761: Fix else section of alternative combined fragment outside widget box.

bug id is https://bugs.kde.org/show_bug.cgi?id=376804

Jul 18 2017, 4:36 AM · Umbrello
habacker closed D6761: Fix else section of alternative combined fragment outside widget box by committing R139:12abb14ecef1: Fix else section of alternative combined fragment outside widget box (authored by astranieri).
Jul 18 2017, 4:32 AM · Umbrello

Jul 17 2017

astranieri created D6761: Fix else section of alternative combined fragment outside widget box.
Jul 17 2017, 8:36 PM · Umbrello

Jan 28 2016

bcooksley set the image for Umbrello to F46617: fa-briefcase-blue.png.
Jan 28 2016, 3:22 AM
bcooksley changed the edit policy for Umbrello.
Jan 28 2016, 3:21 AM

Jan 3 2016

bcooksley removed a member for Umbrello: bcooksley.
Jan 3 2016, 7:44 PM
habacker edited Description on Umbrello.
Jan 3 2016, 2:28 PM
habacker added a member for Umbrello: habacker.
Jan 3 2016, 8:59 AM
bcooksley created Umbrello.
Jan 3 2016, 5:41 AM