With https://bugs.kde.org/show_bug.cgi?id=401290#c7 I can confirm, that this the related bug is really fixed by this patch.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Nov 26 2018
Nov 25 2018
Another view is that this patch bypasses the originally described error (the dialog box).
I changed the title as you suggest.
From my point of view, the whole point of bug 401290 was to get rid of the annoying dialogs popping up.
So I would argue that this does in fact fix the issue, even in a way that has an improvement in portability as a side effect.
Nov 23 2018
The title of this commit is inappropriate, because the patch does not fix the initially reported regression, but converts the java specific notation '...' into a language independent array definition.
Nov 22 2018
Jan 18 2018
Version 2.24.0 contains php import support
Jan 8 2018
package has been added
Dec 16 2017
win64 package is created at https://build.opensuse.org/project/show/home:rhabacker:branches:windows:mingw:win32:KDE4
Need to released to windows:mingw:winxx after finishing sub tasks
Dec 2 2017
Aug 6 2017
Application of code review comments
Aug 3 2017
In D6846#131485, @astranieri wrote:I applied the comments regarding the braces.
Furthermore, I have fixed the patch, in that it was missing:
- re-naming for some variable to reflect their actual type and be less confusing in my opinion
- removes unused include directives
While it is nice that you cover this, I do not like mixing the initial fix with unrelated changes, which makes it hard to see what has been really changed and what is only cosmetic. Think about the case you need to inspect single commits say in one year because there is an hidden issue. In case there are commits covering a single topic you can save much time by simply skipping the cosmetic and unrelated commits. With mixed commits you need to inspect every commit if it contains real changes or not.
I do not know if phabricator supports a set of patches in one request. If not feel free to open new review requests for each additional topic. You may collect removing unused include directives patches in a separate local git branch and post them as one patch later to a single review request.
Aug 2 2017
I applied the comments regarding the braces.
Sure, that's actually my style too. I saw that if blocks are in Java style and I mistakenly thought that would apply to methods as well. I will fix it.
Aug 1 2017
looks good otherwise. After fixing the mentioned issues it could be applied to master because this patch changes the location of i18n calls which is not allowed in stable branches.
Jul 30 2017
Jul 24 2017
Jul 23 2017
Jul 18 2017
We missed the time frame for 2.22.80. Fix will be in release 2.22.90