https://invent.kde.org/kde/umbrello/-/merge_requests/4 is a followup of this request

I have everything configured correctly now and have completed the merge
request.

PS: phabricator is not good at managing reviews that consist of multiple patches. A better way to do this is to create a fork from the project https://invent.kde.org/kde/umbrello, push the patches into a separate branch and create a merge request.
See https://invent.kde.org/kde/umbrello/-/merge_requests/3 for an example.

In D27584#617299, @jhayes wrote:

The requested changes have been made,

Please update the patch with the changes applied

The requested changes have been made, I will run a diff and double check then submit the changes on 2/25.

Thanks.

Here you go, and thanks you for your patience.

The last bunch of minor issues found while translating this. Thanks in advance for fixing them and for your patience.

Apologize for the typos.

Thanks in advance for fixing these minor typos. Sorry for overlooking them before.

Thanks. But again, please

Fix xml typos

See the update revision D27584

In D27575#616222, @jhayes wrote:

It doesn't appear to be an option for me.

It doesn't appear to be an option for me.

And one more typo.

Please select "abandon ..." in the add action drop down list.

Thanks for all of the comments, I will get the minor fixes wraped up today.

There is also a line for specifying the version with which this extension request was added for the news and changelog (e.g https://umbrello.kde.org/changelog.php?20.04

And two more fixes.

Thanks in advance for fixing these minor issues.

Thanks for fixing the i18n() issue.

I can't comment on the code, but the bug number should not be in the first line of the commit message.

All tooltips should be in i18n() to be translatable, not in QLatin1String and not in tr().

Sure, I will look at those, I do have a fair amount of time.

In D27201#607195, @jhayes wrote:

I am rooting around now for what to work on next.

I am rooting around now for what to work on next.

I'm going to apply this with a cleanup I found on testing this patch. Thanks for contributing

• Change the other call to help and add missing image

Looks good, except for the missing file and the mentioned issues, which needs an update. Since this commit affects translations, and the stable branch is locked for changes, this commit would have to go to the master branch.

There is some progress in https://invent.kde.org/carlschwan/umbrello-kde-org :)

In D26419#588155, @okellogg wrote:

I followed the steps you described and created a merge request:
https://invent.kde.org/kde/umbrello/merge_requests/1

I merged this request into git master branch of kde/umbrello, thank you for your contribution.

I followed the steps you described and created a merge request:
https://invent.kde.org/kde/umbrello/merge_requests/1

If you do not know how to create a merge request, you must do so:

1. register at https://invent.kde.org.
2. fork https://invent.kde.org/kde/umbrello into your home project (click on button 'fork')
3. git clone your forked umbrello project
4. apply changes to the desired branch of the checked-out git repository
5. push the current branch into your forked umbrello project

Please commit this patch yourself, otherwise I will be listed as author, as the unpatched arc does not use the original author or create a merge request.

BTW: there is a new way to submit code changes to umbrello by creating gitlab merge requests at https://invent.kde.org/kde/umbrello/merge_requests

I was using a local version (that was unreleased until 4 days ago) ;)

• Change local path

Thanks for doing this work.

[spam comment removed by sysadmin]

Current look in D23543

Thanks for your contribution.

Patches should be posted as a Phabricator review.

In T7659#170480, @bcooksley wrote:

Patches are welcome.

where to send patch - to a phabricator task or posting a code review ?

In T7659#170455, @habacker wrote:

In T7659#170406, @bcooksley wrote:

Luigi is correct, unless your Craft targets are setup accordingly, the system is probably building from Git.

Who can setup this ?

In T7659#170456, @habacker wrote:

In T7659#170393, @habacker wrote:

It's a bit hacky right now, see for example this snippet:

If that is all, there is no problem to switch to DTD version 4.5 and to use a workaround in the other case.

fixed with https://cgit.kde.org/umbrello.git/commit/?h=Applications/18.12&id=626de6de7889b4724394cd47901fae5249ce7ec7 and merged into master

In T7659#170406, @bcooksley wrote:

As for the crash, you'll probably need to build Umbrello using Craftmaster locally in order to ensure all the debug symbols are available as we don't ship them with applications.

In T7659#170393, @habacker wrote:

It's a bit hacky right now, see for example this snippet:

If that is all, there is no problem to switch to DTD version 4.5 and to use a workaround in the other case.

In T7659#170406, @bcooksley wrote:

Luigi is correct, unless your Craft targets are setup accordingly, the system is probably building from Git.

Who can setup this ?

Here are a few related KF5/Windows bugs:

Luigi is correct, unless your Craft targets are setup accordingly, the system is probably building from Git.

That's the build from binary factory, which is true (if I remember correctly) for all nightly snapshots. Builds from tarballs include the translations.

The first, there is only english available

In T7659#170393, @habacker wrote:

3. umbrello/KF5 does not have any language support

It's a bit hacky right now, see for example this snippet:

The time I tried, the infrastructure didn't work. I should dig my old emails, but I'm sure I explained it by and large elsewhere.
It's a bit hacky right now, see for example this snippet:

kdelibs4support is a Porting Aid, and not a native part of KF5.