Properly kill AddToArchive jobs
ClosedPublic
Actions

Authored by elvisangelaccio on Jan 7 2017, 12:25 PM.

Details

Reviewers

Commits

R36:e777831fe4a7: Properly kill AddToArchive jobs

Summary

Both AddToArchive and CreateJob are wrapper jobs, they need to implement
doKill() and call kill() on the actual jobs that are doing the work.

BUG: 374433
FIXED-IN: 16.12.1

Test Plan

Compress a big folder from Dolphin, stop job from system tray. Crash is gone.

Repository

R36 Ark

Branch

bug/374433

Lint

No Linters Available

Unit

No Unit Test Coverage

elvisangelaccio retitled this revision from to Properly kill AddToArchive jobs.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

Restricted Application added a project: Ark. · View Herald TranscriptJan 7 2017, 12:25 PM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

Fixes the bug for me :)

This revision is now accepted and ready to land.Jan 8 2017, 1:19 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kerfuffle/addtoarchive.h (4 lines)
M			kerfuffle/addtoarchive.cpp (15 lines)
M			kerfuffle/jobs.h (4 lines)
M			kerfuffle/jobs.cpp (15 lines)
M			plugins/libarchive/libarchiveplugin.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9816	82fdfd2		Jan 7 2017, 12:25 PM	★	★
Diff 2	9865	0e8dfd1	R36:e777831fe4a7cdb3b41f4be521d6a8531df63147	Jan 8 2017, 4:13 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0ef7a05bc9bc	4ddae652e18b	3f63a27426e2	Elvis Angelaccio	simplify doKill()s	Jan 7 2017, 12:18 PM
3f63a27426e2	1a0cb211acf1	983b22f994d2	Elvis Angelaccio	kill++	Jan 7 2017, 12:14 PM
983b22f994d2	e8eef9e24ce6	82fdfd24d469	Elvis Angelaccio	Implement doKill()	Jan 7 2017, 11:29 AM