Details

Reviewers

Commits

R838:0d2bd657963c: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

Summary

Instead of creating the pipewire feeds in the portal, they will be
created in KWin.
Then the portal task becomes to orchestrate the permission and delivery
to the app.

Depends on D28882

Test Plan

None yet, just a PoC

Diff Detail

Repository

R838 Flatpak Support: KDE Portal for XDG Desktop

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25627
Build 25645: arc lint + arc unit

apol created this revision.Apr 16 2020, 2:38 PM

Restricted Application added a project: Plasma. · View Herald TranscriptApr 16 2020, 2:38 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

apol requested review of this revision.Apr 16 2020, 2:38 PM

Harbormaster completed remote builds in B25317: Diff 80280.Apr 16 2020, 2:38 PM

Fix build

Harbormaster completed remote builds in B25321: Diff 80285.Apr 16 2020, 3:00 PM

Include the notification

Harbormaster completed remote builds in B25358: Diff 80340.Apr 17 2020, 12:36 AM

jgrulich added a subscriber: jgrulich.Apr 17 2020, 8:30 AM

jgrulich added inline comments.

src/waylandintegration_p.h
116–117	Shouldn't we rename this variable so it reflects the interface it uses?

Renamed classes

Harbormaster completed remote builds in B25387: Diff 80408.Apr 17 2020, 4:31 PM

Adadpt to changes in kwayland D28882

Harbormaster completed remote builds in B25526: Diff 80663.Apr 20 2020, 4:28 PM

apol mentioned this in D29015: Move screencasting to KWin.Apr 20 2020, 4:46 PM

Proper initialisation

Harbormaster completed remote builds in B25569: Diff 80719.Apr 21 2020, 12:27 AM

With all code relevant to PipeWire removed, you can remove all needed CMake find modules in cmake subdir and you can also remove the ENABLE_PIPEWIRE option as it shouldn't be needed anymore (including all ifdefs).

jgrulich added inline comments.Apr 21 2020, 12:18 PM

src/waylandintegration.cpp
310	This has been removed, but I think it will still be needed.

Remove conditional compilation to pipewire

It's not in this module, we don't need to depend on it.
Also removes code regarding EGL initialization that I think now is not necessary.

Harbormaster completed remote builds in B25626: Diff 80795.Apr 21 2020, 5:34 PM

Remember to run the event loop

Harbormaster completed remote builds in B25627: Diff 80797.Apr 21 2020, 5:56 PM

Adopt kwayland changes, provide the right buffer size.

Harbormaster completed remote builds in B25753: Diff 80985.Apr 23 2020, 11:33 AM

Generally +1

src/waylandintegration.cpp
452	leftover

Looks good and it works for me, tested with Chromium.

This revision is now accepted and ready to land.Apr 23 2020, 3:05 PM

Adapt to the changes in hte kwayland patch

Harbormaster completed remote builds in B25840: Diff 81115.Apr 24 2020, 4:57 PM

Explicitly request zkde_screencast_unstable_v1

Harbormaster completed remote builds in B25984: Diff 81343.Apr 27 2020, 2:11 PM

Rebase on top of kwayland-server changes

Harbormaster completed remote builds in B26345: Diff 81926.May 4 2020, 5:29 PM

Adapt to changes in the protocol, implement windows

Harbormaster completed remote builds in B26587: Diff 82302.May 8 2020, 6:00 PM

Closed by commit R838:0d2bd657963c: screencasting: Adoption of the org_kde_plasma_video_streaming protocol (authored by apol). · Explain WhyMay 18 2020, 5:03 PM

This revision was automatically updated to reflect the committed changes.

This is on https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/1 now.

		Path
M		CMakeLists.txt (30 lines)
D	M	cmake/modules/FindEpoxy.cmake (60 lines)
D	M	cmake/modules/FindGBM.cmake (107 lines)
D	M	cmake/modules/FindPipeWire.cmake (122 lines)
M		data/CMakeLists.txt (6 lines)
D	M	data/kde-no-pipewire.portal (4 lines)
M		src/CMakeLists.txt (31 lines)
M		src/desktopportal.h (5 lines)
M		src/desktopportal.cpp (2 lines)
M		src/remotedesktop.cpp (4 lines)
M		src/remotedesktopdialog.h (3 lines)
M		src/remotedesktopdialog.cpp (2 lines)
M		src/screencast.cpp (9 lines)
D	M	src/screencaststream.h (125 lines)
D	M	src/screencaststream.cpp (611 lines)
M		src/screencastwidget.h (3 lines)
M		src/screencastwidget.cpp (27 lines)
M		src/screenchooserdialog.h (3 lines)
M		src/screenchooserdialog.cpp (2 lines)
M		src/waylandintegration.h (28 lines)
M		src/waylandintegration.cpp (339 lines)
M		src/waylandintegration_p.h (45 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80280	d1f0ec4		Apr 16 2020, 2:38 PM	★	★
Diff 2	80285	d1f0ec4	Fix build	Apr 16 2020, 3:00 PM	★	★
Diff 3	80340	d1f0ec4	Include the notification	Apr 17 2020, 12:36 AM	★	★
Diff 4	80408	c3c840e	Renamed classes	Apr 17 2020, 4:31 PM	★	★
Diff 5	80663	c3c840e	Adadpt to changes in kwayland D28882	Apr 20 2020, 4:28 PM	★	★
Diff 6	80719	c3c840e	Proper initialisation	Apr 21 2020, 12:27 AM	★	★
Diff 7	80795	c3c840e	Remove conditional compilation to pipewire	Apr 21 2020, 5:34 PM	★	★
Diff 8	80797	c3c840e	Remember to run the event loop	Apr 21 2020, 5:56 PM	★	★
Diff 9	80985	c3c840e	Adopt kwayland changes, provide the right buffer size.	Apr 23 2020, 11:33 AM	★	★
Diff 10	81115	c3c840e	Adapt to the changes in hte kwayland patch	Apr 24 2020, 4:57 PM	★	★
Diff 11	81343	53360ee	Explicitly request zkde_screencast_unstable_v1	Apr 27 2020, 2:11 PM	★	★
Diff 12	81926	66fa27c	Rebase on top of kwayland-server changes	May 4 2020, 5:29 PM	★	★
Diff 13	82302	66fa27c	Adapt to changes in the protocol, implement windows	May 8 2020, 6:00 PM	★	★
Diff 14	83050	ab81c2e	R838:0d2bd657963c2c7272ba9bbb0f8b9dd57af0dbda	May 18 2020, 10:55 AM	★	★

	Status	Author	Revision
	Closed	apol	D28884 screencasting: Adoption of the org_kde_plasma_video_streaming protocol
	Abandoned	apol	D28882 Create protocol to manage video feeds

screencasting: Adoption of the org_kde_plasma_video_streaming protocol
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 80797

CMakeLists.txt

cmake/modules/FindEpoxy.cmake

cmake/modules/FindGBM.cmake

cmake/modules/FindPipeWire.cmake

data/CMakeLists.txt

data/kde-no-pipewire.portal

src/CMakeLists.txt

src/desktopportal.h

src/desktopportal.cpp

src/remotedesktop.cpp

src/remotedesktopdialog.h

src/remotedesktopdialog.cpp

src/screencast.cpp

src/screencaststream.h

src/screencaststream.cpp

src/screencastwidget.h

src/screencastwidget.cpp

src/screenchooserdialog.h

src/screenchooserdialog.cpp

src/waylandintegration.h

src/waylandintegration.cpp

src/waylandintegration_p.h

screencasting: Adoption of the org_kde_plasma_video_streaming protocolClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 80797

CMakeLists.txt

cmake/modules/FindEpoxy.cmake

cmake/modules/FindGBM.cmake

cmake/modules/FindPipeWire.cmake

data/CMakeLists.txt

data/kde-no-pipewire.portal

src/CMakeLists.txt

src/desktopportal.h

src/desktopportal.cpp

src/remotedesktop.cpp

src/remotedesktopdialog.h

src/remotedesktopdialog.cpp

src/screencast.cpp

src/screencaststream.h

src/screencaststream.cpp

src/screencastwidget.h

src/screencastwidget.cpp

src/screenchooserdialog.h

src/screenchooserdialog.cpp

src/waylandintegration.h

src/waylandintegration.cpp

src/waylandintegration_p.h

screencasting: Adoption of the org_kde_plasma_video_streaming protocol
ClosedPublic
Actions

Revision Contents
Changeset List