Differential D28798

Make warning and error messages grammatically correct
ClosedPublic
Actions

Authored by ngraham on Apr 13 2020, 4:21 PM.

Details

Reviewers
ivan
Group Reviewers
VDG
Commits
R845:d17f0e717fcf: Make warning and error messages grammatically correct
Summary

These messages are currently comma splices, which are incorrect.

Diff Detail

Repository
R845 Plasma Vault
Branch
fix-grammar (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25168
Build 25186: arc lint + arc unit
ngraham created this revision.Apr 13 2020, 4:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 13 2020, 4:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 13 2020, 4:21 PM
ivan added a comment.Apr 13 2020, 4:48 PM

Maybe "Unable to close the vault; it is being used by %1" -> "Unable to close the vault as it is being used by %1" ?

"Unable to close the vault; an application is using it" -> "Unable to close the vault because an application is using it"

While writing for Manning, I was told to avoid semicolons and try to rephrase the sentence instead.

ngraham updated this revision to Diff 80031.Apr 13 2020, 4:55 PM

"because" is better

ivan accepted this revision.Apr 13 2020, 6:27 PM
This revision is now accepted and ready to land.Apr 13 2020, 6:27 PM
Closed by commit R845:d17f0e717fcf: Make warning and error messages grammatically correct (authored by ngraham). · Explain WhyApr 13 2020, 6:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/engine/vault.cpp (14 lines)

Diff 80030

View Options

kded/engine/vault.cpp

Loading...