Rework file numbering
ClosedPublic

Authored by davidre on Mar 26 2020, 4:48 PM.

Details

Summary

Previously we looped though every match and checked the filesystem every
iteration. Now we do it only once which should result in better performance. I
also added a test case that shows that the old method was broken, too.

Test Plan

run tests

Diff Detail

Repository
R166 Spectacle
Branch
regexp (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24467
Build 24485: arc lint + arc unit
davidre created this revision.Mar 26 2020, 4:48 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptMar 26 2020, 4:48 PM
davidre requested review of this revision.Mar 26 2020, 4:48 PM
ngraham added inline comments.
src/ExportManager.cpp
225

leftover?

tests/FilenameTest.cpp
85

ditto

davidre updated this revision to Diff 78896.Mar 30 2020, 1:43 PM

remove leftover qdebug

ngraham accepted this revision.Mar 30 2020, 1:43 PM
This revision is now accepted and ready to land.Mar 30 2020, 1:43 PM
This revision was automatically updated to reflect the committed changes.