kwinglplatformtest still passes.
Details
Details
- Reviewers
apol - Group Reviewers
KWin - Commits
- R108:9755ef20e585: [kwineffects] Port GLPlatform to QRegularExpression
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- port-kwinglplatform-to-qregularexpression
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 24293 Build 24311: arc lint + arc unit
libkwineffects/kwinglplatform.cpp | ||
---|---|---|
97 | It could make sense to return a QStringRef, we'd get to save a bunch of string allocations and copies. |
libkwineffects/kwinglplatform.cpp | ||
---|---|---|
97 | Yes, it would be great, but could we maybe do it in another patch? QString and QStringRef have minor API differences so it's not just about replacing a few QStrings by QStringRefs. Such a change would look unrelated if you ask me. |
libkwineffects/kwinglplatform.cpp | ||
---|---|---|
97 | Yes, the patch is accepted, feel free to land. |