[kwineffects] Port GLPlatform to QRegularExpression
ClosedPublic

Authored by zzag on Mar 26 2020, 8:35 PM.

Details

Test Plan

kwinglplatformtest still passes.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Mar 26 2020, 8:35 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 26 2020, 8:35 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Mar 26 2020, 8:35 PM
apol accepted this revision.Mar 27 2020, 12:24 AM
apol added a subscriber: apol.
apol added inline comments.
libkwineffects/kwinglplatform.cpp
97

It could make sense to return a QStringRef, we'd get to save a bunch of string allocations and copies.

This revision is now accepted and ready to land.Mar 27 2020, 12:24 AM
zzag added inline comments.Mar 27 2020, 7:48 AM
libkwineffects/kwinglplatform.cpp
97

Yes, it would be great, but could we maybe do it in another patch? QString and QStringRef have minor API differences so it's not just about replacing a few QStrings by QStringRefs. Such a change would look unrelated if you ask me.

apol added inline comments.Mar 27 2020, 11:09 AM
libkwineffects/kwinglplatform.cpp
97

Yes, the patch is accepted, feel free to land.

This revision was automatically updated to reflect the committed changes.