[kioslave/remote] Port away from kdelibs4support
ClosedPublic
Actions

Authored by elvisangelaccio on Nov 3 2016, 10:25 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

The remote:/ kioslave now builds without kdelibs4support.
The second commit also removes the tests subfolder, since the executable was a
noop.

Test Plan

remote:/ still works in Dolphin.

Repository

R120 Plasma Workspace

Branch

port-remote

Lint

No Linters Available

Unit

No Unit Test Coverage

elvisangelaccio retitled this revision from to [kioslave/remote] Port away from kdelibs4support.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart added a reviewer: mart.

This revision is now accepted and ready to land.Nov 4 2016, 10:21 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		kioslave/remote/CMakeLists.txt (3 lines)
M		kioslave/remote/kdedmodule/CMakeLists.txt (2 lines)
M		kioslave/remote/kdedmodule/remotedirnotify.h (8 lines)
M		kioslave/remote/kdedmodule/remotedirnotify.cpp (66 lines)
M		kioslave/remote/kdedmodule/remotedirnotifymodule.cpp (4 lines)
M		kioslave/remote/kio_remote.cpp (12 lines)
M		kioslave/remote/remoteimpl.h (6 lines)
M		kioslave/remote/remoteimpl.cpp (40 lines)
D	M	kioslave/remote/tests/CMakeLists.txt (15 lines)
D	M	kioslave/remote/tests/testremote.h (34 lines)
D	M	kioslave/remote/tests/testremote.cpp (51 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7853	bd0eb99		Nov 3 2016, 10:25 AM	★	★
Diff 2	7890	4352391	rPLASMAWORKSPACE72e39f083a103e0887624482d6a0ce8b0556dd5e	Nov 4 2016, 10:33 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
891127c3fa5c	30c6a412592b	5333d234d5f9	Elvis Angelaccio	[kioslave/remote] Remove unused tests folder	Nov 3 2016, 10:15 AM
5333d234d5f9	2c7c0572026e	bd0eb992d8d9	Elvis Angelaccio	[kioslave/remote] Port away from kdelibs4support	Nov 2 2016, 12:27 PM