[shell] Don't resize or reposition panel if we are doing restore
ClosedPublic

Authored by bshah on Oct 10 2016, 3:57 PM.

Details

Summary

PanelView::restore sets various properties including length, thickness,
which would result in panel resize and repositioning. PanelView::restore
also explicitly calls PanelView::positionPanel and ::resizePanel.

This results in positionPanel and resizePanel operation being done
multiple times at startup/adding panel and hence flicker when panel
first shows up. This patch makes resizePanel and positionPanel no-op if
we are restoring panel.

Test Plan

Added panel, restored panel, moved around panel

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
bshah updated this revision to Diff 7269.Oct 10 2016, 3:57 PM
bshah retitled this revision from to [shell] Don't resize or reposition panel if we are doing restore.
bshah updated this object.
bshah edited the test plan for this revision. (Show Details)
bshah added reviewers: Plasma, mart.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 10 2016, 3:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added inline comments.Oct 10 2016, 4:05 PM
shell/panelview.h
212

code looks a bit weird but i see what it's trying to do..

i would give it another name, like m_initCompleted

bshah updated this revision to Diff 7270.Oct 10 2016, 4:08 PM

rename var

mart accepted this revision.Oct 10 2016, 4:10 PM
mart edited edge metadata.
This revision is now accepted and ready to land.Oct 10 2016, 4:10 PM
This revision was automatically updated to reflect the committed changes.