Differential D25792

Add notifiers to workspace options kcfg
ClosedPublic
Actions

Authored by davidedmundson on Dec 6 2019, 7:02 PM.

Details

Reviewers
ervin
Commits
R119:8b00bcb9bc09: Add notifiers to workspace options kcfg
Summary

A write flag got lost in the KCFG port. This adds it back.

Test Plan

dragged slider, kwin animation speed reloaded

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19558
Build 19576: arc lint + arc unit
davidedmundson created this revision.Dec 6 2019, 7:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 6 2019, 7:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 6 2019, 7:02 PM
davidedmundson added a dependency: D25791: Fix writeFlags with KConfigCompilerSignallingItem.Dec 6 2019, 7:02 PM

Linked revision is needed to have it work properly.

ervin accepted this revision.Dec 10 2019, 8:33 AM
This revision is now accepted and ready to land.Dec 10 2019, 8:33 AM
Closed by commit R119:8b00bcb9bc09: Add notifiers to workspace options kcfg (authored by davidedmundson). · Explain WhyDec 10 2019, 8:45 AM
This revision was automatically updated to reflect the committed changes.
crossi added a subscriber: crossi.Dec 10 2019, 1:10 PM

Thanks @davidedmundson for spotting this regression.

Actually, only AnimationDurationFactor should notify.

From D25586
See kcms/workspaceoptions/workspaceoptions.cpp line 221.

Revision Contents
Changeset List

Diff 71030

View Options

kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

Loading...