Fixed issue when time zone configuration page was not scaling corrently. As a result two
srollbars were rendered.
Fixed few QML layout warnings and undefined references.
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma Plasma: Workspaces - Commits
- R120:82cfabd0a5c8: [DigitalClock] Fix layout and QML warnings
Open Time zones configuration page and shrink window - two scrollbars are rendered.
Expected: table is scalled correctly and only one scrollbar in table is rendered.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Concept +1, I love layouts
applets/digital-clock/package/contents/ui/configTimeZones.qml | ||
---|---|---|
31–32 | Do you need these? Generally it's a sign of a problem or bad layering if the root item has anchors in it. | |
54 | If we're going to port stuff, we may as well port to: https://api.kde.org/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1InlineMessage.html the library version of this | |
88 | What's this for? Opacity should be inherited by children |
Comment Actions
Fair enough, that seems reasonable.
applets/digital-clock/package/contents/ui/configTimeZones.qml | ||
---|---|---|
58 | Don't use hardcoded margins. This should be Kirigami.Units.smallSpacing |
applets/digital-clock/package/contents/ui/configTimeZones.qml | ||
---|---|---|
58 | I just copied values form the original Rectangle. I will remove it entirely, probably it's not needed anymore. |