Differential D24834

[KCM] Try harder to display all text in the visualizations
ClosedPublic
Actions

Authored by ngraham on Oct 21 2019, 3:24 PM.

Details

Reviewers
romangg
Group Reviewers
Plasma
Commits
R104:3c406779cca9: [KCM] Try harder to display all text in the visualizations
Summary

5.17

Test Plan

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 21 2019, 3:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2019, 3:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 21 2019, 3:24 PM
romangg added a comment.Oct 21 2019, 4:45 PM

Looks good. If the display is too small to display two rows or the name is even longer, does it just elide?

One question I have long term is what information actually needs to be in there. Currently we have name and the logical size. Would only the name or name + resolution make more sense?

ngraham added a comment.EditedOct 21 2019, 4:46 PM
In D24834#551506, @romangg wrote:

Looks good. If the display is too small to display two rows or the name is even longer, does it just elide?

Yep.

One question I have long term is what information actually needs to be in there. Currently we have name and the logical size. Would only the name or name + resolution make more sense?

Unless I'm misunderstanding things, it's already is showing the name and the resolution. The name is mandatory I think; not so sure about the resolution.

ngraham added a comment.Oct 21 2019, 4:51 PM

You good with getting this into 5.17 now, and we can investigate what should be displayed in there for 5.18?

romangg accepted this revision.Oct 21 2019, 5:18 PM
In D24834#551507, @ngraham wrote:
In D24834#551506, @romangg wrote:

Looks good. If the display is too small to display two rows or the name is even longer, does it just elide?

Yep.

One question I have long term is what information actually needs to be in there. Currently we have name and the logical size. Would only the name or name + resolution make more sense?

Unless I'm misunderstanding things, it's already is showing the name and the resolution. The name is mandatory I think; not so sure about the resolution.

It shows the logical size. If you have a 3840x2160 resolution screen with scale factor 2, it shows 1920x1080. I guess it's this way only on Wayland

In D24834#551510, @ngraham wrote:

You good with getting this into 5.17 now, and we can investigate what should be displayed in there for 5.18?

Yes, 5.17.

This revision is now accepted and ready to land.Oct 21 2019, 5:18 PM
romangg added a comment.EditedOct 21 2019, 5:19 PM

Add a more meaningful summary please and replace the 5.17 text with it.

Closed by commit R104:3c406779cca9: [KCM] Try harder to display all text in the visualizations (authored by ngraham). · Explain WhyOct 21 2019, 5:20 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Oct 21 2019, 5:22 PM
In D24834#551549, @romangg wrote:

Add a more meaningful summary please and replace the 5.17 text with it.

Oops sorry, I missed this before landing it. :(

Revision Contents
Changeset List

PathPackages
Mkcm/package/contents/ui/Output.qml (7 lines)

Diff 68466

View Options

kcm/package/contents/ui/Output.qml

Loading...